i2c: properly handle bus errors #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
almusil
reviewed
May 27, 2020
src/i2c.rs
Outdated
| while self.i2c.isr.read().rxne().bit_is_clear() {} | ||
| while self.i2c.isr.read().rxne().bit_is_clear() { | ||
| let isr = self.i2c.isr.read(); | ||
| if isr.berr().bit_is_set() { |
There was a problem hiding this comment.
What about reusing the whole error handling block? send_byte uses almost the same thing. It can be separated to the function.
There was a problem hiding this comment.
This has been done in #102, I think, so rebase should take care of this comment.
|
Done. Basically only one change left after rebasing, but I think that it is still worth to add. |
|
Thank you, @hlukasz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In send_byte() wait for TX fifo empty before returning Ok. It would be
better to wait for end of transmission, but there is no such field in
I2C status register.
In recv_byte() return Err if error condition detected while waiting for
byte.
Before starting new transaction ensure that both TX and RX buffers are
empty. There are some corner cases where something may be there.