Skip to content

Commit

Permalink
Merge pull request #28876 from storybookjs/norbert/vite-hmr-fix
Browse files Browse the repository at this point in the history
Vite: Fix HMR
  • Loading branch information
ndelangen committed Aug 13, 2024
2 parents d2e377d + fe8bf33 commit ac5d162
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 7 deletions.
12 changes: 6 additions & 6 deletions code/builders/builder-vite/src/plugins/code-generator-plugin.ts
Original file line number Diff line number Diff line change
Expand Up @@ -70,33 +70,33 @@ export function codeGeneratorPlugin(options: Options): Plugin {
},
resolveId(source) {
if (source === virtualFileId) {
return `\0${virtualFileId}`;
return `${virtualFileId}`;
}
if (source === iframePath) {
return iframeId;
}
if (source === virtualStoriesFile) {
return `\0${virtualStoriesFile}`;
return `${virtualStoriesFile}`;
}
if (source === virtualPreviewFile) {
return virtualPreviewFile;
}
if (source === virtualAddonSetupFile) {
return `\0${virtualAddonSetupFile}`;
return `${virtualAddonSetupFile}`;
}

return undefined;
},
async load(id, config) {
if (id === `\0${virtualStoriesFile}`) {
if (id === `${virtualStoriesFile}`) {
return generateImportFnScriptCode(options);
}

if (id === `\0${virtualAddonSetupFile}`) {
if (id === `${virtualAddonSetupFile}`) {
return generateAddonSetupCode();
}

if (id === `\0${virtualFileId}`) {
if (id === `${virtualFileId}`) {
return generateModernIframeScriptCode(options, projectRoot);
}

Expand Down
5 changes: 4 additions & 1 deletion code/e2e-tests/save-from-controls.spec.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { test } from '@playwright/test';
import { expect, test } from '@playwright/test';
import process from 'process';

import { SbPage } from './util';
Expand Down Expand Up @@ -68,5 +68,8 @@ test.describe('save-from-controls', () => {
const notification2 = await sbPage.page.waitForSelector('[title="Story created"]');
await notification2.isVisible();
await notification2.click();

// Assert the Button components is rendered in the preview
await expect(sbPage.previewRoot()).toContainText('Button');
});
});

0 comments on commit ac5d162

Please sign in to comment.