Merge pull request #28875 from storybookjs/yann/enable-next-vite-sand…

…boxes Build: Enable Nextjs-Vite sandboxes
storybookjs · Aug 13, 2024 · d2e377d · d2e377d
2 parents ac162a5 + cf7ddab
commit d2e377d
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -814,30 +814,30 @@ workflows:
           requires:
             - build
       - create-sandboxes:
-          parallelism: 37
+          parallelism: 38
           requires:
             - build
       # - smoke-test-sandboxes: # disabled for now
       #     requires:
       #       - create-sandboxes
       - build-sandboxes:
-          parallelism: 37
+          parallelism: 38
           requires:
             - create-sandboxes
       - chromatic-sandboxes:
-          parallelism: 34
+          parallelism: 35
           requires:
             - build-sandboxes
       - e2e-production:
-          parallelism: 32
+          parallelism: 33
           requires:
             - build-sandboxes
       - e2e-dev:
           parallelism: 2
           requires:
             - create-sandboxes
       - test-runner-production:
-          parallelism: 32
+          parallelism: 33
           requires:
             - build-sandboxes
       - test-portable-stories:

diff --git a/code/lib/cli-storybook/src/sandbox-templates.ts b/code/lib/cli-storybook/src/sandbox-templates.ts
@@ -208,13 +208,11 @@ const baseTemplates = {
     name: 'Next.js Latest (Vite | TypeScript)',
     script:
       'yarn create next-app {{beforeDir}} --typescript --eslint --tailwind --app --import-alias="@/*" --src-dir',
-    inDevelopment: true,
     expected: {
       framework: '@storybook/experimental-nextjs-vite',
       renderer: '@storybook/react',
       builder: '@storybook/builder-vite',
     },
-
     modifications: {
       mainConfig: {
         framework: '@storybook/experimental-nextjs-vite',

diff --git a/scripts/tasks/generate.ts b/scripts/tasks/generate.ts
@@ -28,8 +28,7 @@ export const generate: Task = {
     }
 
     // This uses an async import as it depends on `lib/cli` which requires `code` to be installed.
-    // @ts-expect-error Default import required for dynamic import processed by esbuild
-    const { generate: generateRepro } = (await import('../sandbox/generate.ts')).default;
+    const { generate: generateRepro } = await import('../sandbox/generate');
 
     await generateRepro({
       templates: [details.key],