Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Enable Nextjs-Vite sandboxes #28875

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Aug 13, 2024

Closes #

What I did

Checklist for Contributors

Testing

The changes in this PR are covered in the following automated tests:

  • stories
  • unit tests
  • integration tests
  • end-to-end tests

Manual testing

This section is mandatory for all contributions. If you believe no manual test is necessary, please state so explicitly. Thanks!

Documentation

  • Add or update documentation reflecting your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Checklist for Maintainers

  • When this PR is ready for testing, make sure to add ci:normal, ci:merged or ci:daily GH label to it to run a specific set of sandboxes. The particular set of sandboxes can be found in code/lib/cli/src/sandbox-templates.ts

  • Make sure this PR contains one of the labels below:

    Available labels
    • bug: Internal changes that fixes incorrect behavior.
    • maintenance: User-facing maintenance tasks.
    • dependencies: Upgrading (sometimes downgrading) dependencies.
    • build: Internal-facing build tooling & test updates. Will not show up in release changelog.
    • cleanup: Minor cleanup style change. Will not show up in release changelog.
    • documentation: Documentation only changes. Will not show up in release changelog.
    • feature request: Introducing a new feature.
    • BREAKING CHANGE: Changes that break compatibility in some way with current major version.
    • other: Changes that don't fit in the above categories.

🦋 Canary release

This PR does not have a canary release associated. You can request a canary release of this pull request by mentioning the @storybookjs/core team here.

core team members can create a canary release here or locally with gh workflow run --repo storybookjs/storybook canary-release-pr.yml --field pr=<PR_NUMBER>

name before after diff z %
createSize 0 B 0 B 0 B - -
generateSize 76.3 MB 76.3 MB 0 B 2.35 0%
initSize 167 MB 167 MB 0 B 2 0%
diffSize 91.1 MB 91.1 MB 0 B 0.41 0%
buildSize 7.42 MB 7.42 MB 0 B 0.73 0%
buildSbAddonsSize 1.61 MB 1.61 MB 0 B -0.73 0%
buildSbCommonSize 195 kB 195 kB 0 B - 0%
buildSbManagerSize 2.29 MB 2.29 MB 0 B 0.73 0%
buildSbPreviewSize 351 kB 351 kB 0 B -0.73 0%
buildStaticSize 0 B 0 B 0 B - -
buildPrebuildSize 4.45 MB 4.45 MB 0 B 0.73 0%
buildPreviewSize 2.97 MB 2.97 MB 0 B -0.73 0%
testBuildSize 0 B 0 B 0 B - -
testBuildSbAddonsSize 0 B 0 B 0 B - -
testBuildSbCommonSize 0 B 0 B 0 B - -
testBuildSbManagerSize 0 B 0 B 0 B - -
testBuildSbPreviewSize 0 B 0 B 0 B - -
testBuildStaticSize 0 B 0 B 0 B - -
testBuildPrebuildSize 0 B 0 B 0 B - -
testBuildPreviewSize 0 B 0 B 0 B - -
name before after diff z %
createTime 6.6s 7.9s 1.2s -1.15 16%
generateTime 19.5s 20.2s 711ms -0.05 3.5%
initTime 16.8s 16.4s -392ms -0.43 -2.4%
buildTime 10.6s 11.4s 834ms -0.35 7.3%
testBuildTime 0ms 0ms 0ms - -
devPreviewResponsive 9.2s 7.6s -1s -543ms -0.74 -20.1%
devManagerResponsive 4.8s 4.5s -302ms -1 -6.6%
devManagerHeaderVisible 864ms 816ms -48ms -0.15 -5.9%
devManagerIndexVisible 891ms 821ms -70ms -0.39 -8.5%
devStoryVisibleUncached 1.6s 1.2s -322ms -0.21 -24.9%
devStoryVisible 903ms 853ms -50ms -0.27 -5.9%
devAutodocsVisible 854ms 708ms -146ms -0.48 -20.6%
devMDXVisible 900ms 702ms -198ms -0.68 -28.2%
buildManagerHeaderVisible 811ms 803ms -8ms 0.23 -1%
buildManagerIndexVisible 813ms 808ms -5ms 0.24 -0.6%
buildStoryVisible 863ms 846ms -17ms 0.19 -2%
buildAutodocsVisible 766ms 740ms -26ms 0.32 -3.5%
buildMDXVisible 708ms 600ms -108ms -1.05 -18%

Greptile Summary

This pull request enables Next.js Vite sandboxes in Storybook by removing the 'inDevelopment' flag from the 'experimental-nextjs-vite/default-ts' template.

  • Removed 'inDevelopment' flag from 'experimental-nextjs-vite/default-ts' template in code/lib/cli-storybook/src/sandbox-templates.ts
  • Simplified import of generate function in scripts/tasks/generate.ts
  • Indicates Next.js Vite integration for Storybook is now stable for CI and production use
  • Improves code clarity by removing TypeScript workaround in generate.ts

@yannbf yannbf added build Internal-facing build tooling & test updates ci:normal labels Aug 13, 2024
@yannbf yannbf self-assigned this Aug 13, 2024
@yannbf yannbf added ci:daily Run the CI jobs that normally run in the daily job. and removed ci:normal labels Aug 13, 2024
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

2 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings

Copy link

nx-cloud bot commented Aug 13, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit cf7ddab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@yannbf yannbf merged commit d2e377d into next Aug 13, 2024
106 of 107 checks passed
@yannbf yannbf deleted the yann/enable-next-vite-sandboxes branch August 13, 2024 09:19
@github-actions github-actions bot mentioned this pull request Aug 13, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants