breaking: svelte-check v4 #2453
Conversation
| }, | ||
| "peerDependencies": { | ||
| "svelte": "^3.55.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0" | ||
| "svelte": "^3.55.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0", | ||
| "typescript": ">=5.0.0" |
There was a problem hiding this comment.
Should we support some versions of Typescript 4? It might be nice for users who haven't been able to upgrade yet if it's not too hard for us
There was a problem hiding this comment.
Thanks for reminding me to bump the Svelte peer dependency to v4 😄 And since v4 has an implicit dependency requirement on TS >=5 we should, too. Better to nudge users towards upgrading
There was a problem hiding this comment.
I think users will have plenty of reason to upgrade on their own since Svelte 5 is so much better. But it'd probably be appreciated if we let them do it in their own time instead of forcing them. It can make things easier to have wider support as you have more flexibility around what order to upgrade various libraries
There was a problem hiding this comment.
This isn't forcing people to jump to Svelte 5, only Svelte 4 - which you need to do before upgrading to 5 anyway.
There was a problem hiding this comment.
yeah, I know. I was just saying people would want to upgrade to Svelte 4 in order to get to 5 so we don't need to push them too hard
devDependencies pinned to Svelte 3 because other packages in this repo still use it. Theoretically we still support Svelte 3 with svelte-check v4 but this gives us the opportunity to adjust that later without a major
|
Is |
|
No it's used within the language server |
Since language-server doesn't have a dependency on it anymore, we don't need it for svelte-check anymore, too
It should just be a dependency in that project then and not svelte-check, right? |
|
No, the setup here is a bit different, we're bundling most of the language-server package but externalize a few dependencies, which we then need to require separately. |
|
Just curious, how is it decided which are bundled or why can't we bundle |
--ignoreis used without--no-tsconfig[svelte-check]--ignoreflag gets overwritten by--tsconfig#1074svelte-preprocess(also see feat: replace svelte-preprocess with barebones TS preprocessor #2452)closes #2243
WIP, will finish after my vacation.