Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

breaking: svelte-check v4 #2453

Merged
merged 12 commits into from
Aug 27, 2024
+138 −217
Merged

breaking: svelte-check v4 #2453

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d01b678
breaking: make TypeScript a peer dependency
dummdidumm Jul 31, 2024
6fda024
breaking: require node 18 or later
dummdidumm Jul 31, 2024
03482d0
breaking: require Svelte 4 or later
dummdidumm Jul 31, 2024
5aca29f
Merge branch 'master' into svelte-check-major
dummdidumm Aug 19, 2024
ea8c0bd
chore: switch from fast-glob to fdir (#2433)
benmccann Aug 19, 2024
6471fae
Merge branch 'master' into svelte-check-major
dummdidumm Aug 19, 2024
7a1f80a
chore: remove svelte-preprocess dependency from svelte-check
dummdidumm Aug 19, 2024
f580633
breaking: throw when `--ignore` is used without `--no-tsconfig`
dummdidumm Aug 20, 2024
6a7f19d
Merge branch 'master' into svelte-check-major
dummdidumm Aug 27, 2024
6fc7299
Update packages/language-server/src/lib/documents/configLoader.ts
dummdidumm Aug 27, 2024
0dc740f
Update packages/svelte-check/src/index.ts
dummdidumm Aug 27, 2024
471112e
4.0
dummdidumm Aug 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/svelte-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@
"chokidar": "^3.4.1",
"picocolors": "^1.0.0",
"sade": "^1.7.4",
"svelte-preprocess": "^5.1.3",
"typescript": "^5.0.3"
"svelte-preprocess": "^5.1.3"
},
"peerDependencies": {
"svelte": "^3.55.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0"
"svelte": "^3.55.0 || ^4.0.0-next.0 || ^4.0.0 || ^5.0.0-next.0",
"typescript": ">=5.0.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we support some versions of Typescript 4? It might be nice for users who haven't been able to upgrade yet if it's not too hard for us

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reminding me to bump the Svelte peer dependency to v4 😄 And since v4 has an implicit dependency requirement on TS >=5 we should, too. Better to nudge users towards upgrading

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think users will have plenty of reason to upgrade on their own since Svelte 5 is so much better. But it'd probably be appreciated if we let them do it in their own time instead of forcing them. It can make things easier to have wider support as you have more flexibility around what order to upgrade various libraries

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't forcing people to jump to Svelte 5, only Svelte 4 - which you need to do before upgrading to 5 anyway.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I know. I was just saying people would want to upgrade to Svelte 4 in order to get to 5 so we don't need to push them too hard

},
"scripts": {
"build": "rollup -c && node ./dist/src/index.js --workspace ./test --tsconfig ./tsconfig.json",
Expand All @@ -51,6 +51,7 @@
"rollup-plugin-cleanup": "^3.2.0",
"rollup-plugin-copy": "^3.4.0",
"svelte-language-server": "workspace:*",
"typescript": "^5.5.2",
"vscode-languageserver": "8.0.2",
"vscode-languageserver-protocol": "3.17.2",
"vscode-languageserver-types": "3.17.2",
Expand Down
37 changes: 5 additions & 32 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.