fix enum type generators template

[sbilello]

This is necessary to solve swagger-api/swagger-codegen#11166
Please take a look @HugoMario

[HugoMario]

you don't need to make this change. It will create a mess on version releases

[HugoMario]

I reviewed and tested changes on this PR, there is a build error on generated code. The error is related to Adapter code

swagger-codegen-generators/src/main/resources/handlebars/Java/modelEnum.mustache

Lines 57 to 68 in 897d9b3

	public static class Adapter extends TypeAdapter<{{#datatypeWithEnum}}{{{.}}}{{/datatypeWithEnum}}{{^datatypeWithEnum}}{{{classname}}}{{/datatypeWithEnum}}> {
	@Override
	public void write(final JsonWriter jsonWriter, final {{#datatypeWithEnum}}{{{.}}}{{/datatypeWithEnum}}{{^datatypeWithEnum}}{{{classname}}}{{/datatypeWithEnum}} enumeration) throws IOException {
	jsonWriter.value(enumeration.getValue());
	}
	@Override
	public {{#datatypeWithEnum}}{{{.}}}{{/datatypeWithEnum}}{{^datatypeWithEnum}}{{{classname}}}{{/datatypeWithEnum}} read(final JsonReader jsonReader) throws IOException {
	Object value = {{#isNumber}}new BigDecimal(jsonReader.nextDouble()){{/isNumber}}{{^isNumber}}jsonReader.{{#isInteger}}nextInt(){{/isInteger}}{{^isInteger}}nextString(){{/isInteger}}{{/isNumber}};
	return {{#datatypeWithEnum}}{{{.}}}{{/datatypeWithEnum}}{{^datatypeWithEnum}}{{{classname}}}{{/datatypeWithEnum}}.fromValue(String.valueOf(value));
	}
	}

[sbilello]

How can I replicate the bug on the adapter? I didn't touch the adapter code

…

On Tue, Sep 21, 2021, 1:52 AM HugoMario ***@***.***> wrote: I reviewed and tested changes on this PR, there is a build error on generated code. The error is related to Adapter code https://github.com/swagger-api/swagger-codegen-generators/blob/897d9b3d01efe8e1f79a5bcb5e44181bf66d1694/src/main/resources/handlebars/Java/modelEnum.mustache#L57-L68 — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#959 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN3GUHRJ6NCEJUNP6J36L3UDBBUTANCNFSM5EDYBQXA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[sbilello]

@HugoMario

mvn test
[INFO] Results:
[INFO] 
[INFO] Tests run: 225, Failures: 0, Errors: 0, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  12.531 s
[INFO] Finished at: 2021-09-21T14:04:17-07:00

I didn't touch the adapter code. Could you please point out the problem?

[HugoMario]

Hey @sbilello,

The adapter code makes a call to the enum value() method, and it's expecting to be string. Since you changed that to received an integer or any other data type, that creates a build error when we use mvn package command to the generated code.

[HugoMario]

this is an eample i use to reproduce the build problem:

openapi: 3.0.3
servers: []
info:
  description: Nested Objct Sample.
  version: "1.0.0"
  title: Nested Object
  termsOfService: 'http://swagger.io/terms/'
  contact:
    email: apiteam@swagger.io
  license:
    name: Apache 2.0
    url: 'http://www.apache.org/licenses/LICENSE-2.0.html'
tags:
  - name: nestedObject
    description: Everything about your Pets
    externalDocs:
      description: Find out more
      url: 'http://swagger.io'
  - name: store
    description: Access to Petstore orders
  - name: user
    description: Operations about user
    externalDocs:
      description: Find out more about our store
      url: 'http://swagger.io'
paths:
  /nestedObject:
    get:
      operationId: checkNestedObject
      parameters:
        - name: nestedObject
          in: query
          description: nested object.
          required: true
          style: deepObject
          schema:
            $ref: '#/components/schemas/NestedObject'
      responses:
        200:
          description: good

externalDocs:
  description: Find out more about Swagger
  url: 'http://swagger.io'
components:
  schemas:
    ObjectWithEnum:
      type: object
      description: The base meeting object.
      properties:
        topic:
          type: string
          description: The meeting's topic.
        type:
          type: integer
          description: |-
            The type of meeting:
            * `1` — An instant meeting.
            * `2` — A scheduled meeting.
            * `3` — A recurring meeting with no fixed time.
            * `8` — A recurring meeting with fixed time.
          default: 2
          #### THIS CAUSES PROBLEM IN THE SERIALIZATION BECAUSE THE ENUMS VALUES ARE NUMBERS AND NOT STRINGS
          enum:
            - 1
            - 2
            - 3
            - 8
          x-enum-descriptions:
            - Instant meeting.
            - Scheduled meeting.
            - Recurring meeting with no fixed time.
            - Recurring meeting with fixed time.
    Parakeet:
      type: object
      properties:
        color:
          type: string
        soundRepeater:
          type: boolean

    NestedObject:
      type: object
      properties:
        name:
          type: string
        types:
          type: array
          items:
            type: string
        parakeet:
          $ref: '#/components/schemas/Parakeet'
        count:
          type: integer
        enable:
          type: boolean

[sbilello]

@HugoMario Thanks for your reply!

I added the fix but I was not able to replicate the bug with the example provided in the above message.

Please check this project that uses your example and generates the corresponding client:
https://github.com/sbilello/swagger-gen-bug-enum-parameters/blob/java8EnumCompilingTest/bug-client/src/main/java/us/test/openapi/graphql/model/ObjectWithEnum.java

I don't see "Adapter" code for the ObjectWithEnum.

Please provide steps to reproduce the problem or eventually open a PR on that test project if the fix provided does not solve the problem.

Thank you again!

[HugoMario]

Hey @sbilello

I just generated code with your changes using the spec i shared here.
then i run:

mvn package

and i got the buid errors. I'll try again later with your changes and let you know.

[sbilello]

@HugoMario I used your spec in that example project. I don't have any build errors. Did you try to clone https://github.com/sbilello/swagger-gen-bug-enum-parameters/tree/java8EnumCompilingTest that contains your spec?
Please check this out: https://github.com/sbilello/swagger-gen-bug-enum-parameters/blob/java8EnumCompilingTest/bug-client/src/main/resources/reproduceBug.yaml
I don't find any error with mvn package on java 8.
If you still encounter problems please list the steps to replicate the errors and the environment that you are working on.
I am not able to replicate it on my local.
Thanks!

[sbilello]

@frantuma @HugoMario @gracekarina Could you please take a look?

[sbilello]

This PR has been rebased and the commits have been squashed.
I opened this PR #978 upon @frantuma request