fix issue for enum #11166 #11171
Closed
fix issue for enum #11166 #11171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HugoMario
reviewed
Sep 21, 2021
| @@ -1058,7 +1058,7 @@ | |||
| </repository> | |||
| </repositories> | |||
| <properties> | |||
| <swagger-codegen-generators-version>1.0.28-SNAPSHOT</swagger-codegen-generators-version> | |||
| <swagger-codegen-generators-version>3.0.29-SNAPSHOT</swagger-codegen-generators-version> | |||
There was a problem hiding this comment.
A 3.0.29-SNAPSHOT version for swagger-codegen-generators repo does not exist. You can check the releases versions here
There was a problem hiding this comment.
The goal was to add my version here once swagger-api/swagger-codegen-generators#978 gets merged and a new release is performed
HugoMario
reviewed
Sep 21, 2021
| @@ -1149,7 +1149,7 @@ | |||
| </repository> | |||
| </repositories> | |||
| <properties> | |||
| <swagger-codegen-generators-version>1.0.28-SNAPSHOT</swagger-codegen-generators-version> | |||
| <swagger-codegen-generators-version>3.0.29-SNAPSHOT</swagger-codegen-generators-version> | |||
There was a problem hiding this comment.
I am waiting for the other PR review so I can update the version correctly once the swagger-api/swagger-codegen-generators#978 is merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.3.0.0branch for changes related to OpenAPI spec 3.0. Default:master.Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
#11166
It can not pass the Jenkins check until this PR swagger-api/swagger-codegen-generators#959 gets merged.
Please take a look @HugoMario