Fix: evaluate and bitwise operator traits and refactoring #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Apr 18, 2024
AurumTheEnd
force-pushed
the
fix/evaluate
branch
2 times, most recently
from
8ecd8ed
to
4310265
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 71.15% 78.99% +7.84%
==========================================
Files 32 39 +7
Lines 721 776 +55
==========================================
+ Hits 513 613 +100
+ Misses 208 163 -45 ☔ View full report in Codecov by Sentry. |
AurumTheEnd
changed the title
AurumTheEnd
force-pushed
the
fix/evaluate
branch
3 times, most recently
from
f7ce58a
to
1b6efdf
Compare
…rr vars Changed all uses in Expressions and TruthTables & in bindings.
…arate mods
...while maintaining their import path as `crate::expressions::{Expression, ExpressionNode}`.
The functions bool, var & vars are now part of the public API.
This reduces code duplication.
AurumTheEnd
force-pushed
the
fix/evaluate
branch
from
1b6efdf
to
ac7c2da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets #10, #11 and #16.
Branch is forked from
feat/truth-table, so this should be meged after #19.