Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: evaluate and bitwise operator traits and refactoring #20

Merged
merged 20 commits into from
Apr 22, 2024
Merged

Fix: evaluate and bitwise operator traits and refactoring #20

merged 20 commits into from
Apr 22, 2024

Commits on Apr 22, 2024

  1. build: bumped pyo3 version

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3761ef1 View commit details
    Browse the repository at this point in the history

  2. refactor!: made Evaluate support with_default, checked & return all e… 

    …rr vars

Changed all uses in Expressions and TruthTables & in bindings.
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    6158a3a View commit details
    Browse the repository at this point in the history

  3. refactor!: split trait impls for Expression into standalone files ins… 

    …ide /traits
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e9b6be8 View commit details
    Browse the repository at this point in the history

  4. refactor!: made BitAnd/Or/Not traits visible everywhere, not only in … 

    …tests
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    2aa0be7 View commit details
    Browse the repository at this point in the history

  5. refactor!: moved Expression, ExpressionNode, utility functions to sep… 

    …arate mods

...while maintaining their import path as `crate::expressions::{Expression, ExpressionNode}`.

The functions bool, var & vars are now part of the public API.
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c0c54a8 View commit details
    Browse the repository at this point in the history

  6. refactor!: changed PowerSet trait to be purely default impl 

    This reduces code duplication.
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7e60905 View commit details
    Browse the repository at this point in the history

  7. fix(ci): bumped upload-artifact version to solve deprecation notice

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    f9bdad1 View commit details
    Browse the repository at this point in the history

  8. feat(tests): added tests for expression/evaluate

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0ec693b View commit details
    Browse the repository at this point in the history

  9. fix: removed leftover debugging println from table tests

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    b60c5dd View commit details
    Browse the repository at this point in the history

  10. feat(test): added expression tests to increase coverage

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    ac7c2da View commit details
    Browse the repository at this point in the history

  11. feat(test): added valuation_to_row_index tests to increase coverage

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    903c8a0 View commit details
    Browse the repository at this point in the history

  12. feat(test): added truth table to_expression test to increase coverage

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    8afa262 View commit details
    Browse the repository at this point in the history

  13. fix: made truth table to_expression return Constant(true) if all rows… 

    … are true
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    c4f3fbb View commit details
    Browse the repository at this point in the history

  14. fix: fixed from_csv_string always having file_row_count >= 1

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    50ae22c View commit details
    Browse the repository at this point in the history

  15. feat(test): added truth table from_csv tests to increase coverage

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    37652e8 View commit details
    Browse the repository at this point in the history

  16. fix(expression): added parentheses to display for Not variant

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    7b2a919 View commit details
    Browse the repository at this point in the history

  17. fix(expression): fixed Display for And or Or expression 

    With test.
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    92bf195 View commit details
    Browse the repository at this point in the history

  18. feat(tests): added tests for Bit trait impls for expressions

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    58929cb View commit details
    Browse the repository at this point in the history

  19. feat(tests): added more tests for expression/evaluate to increase cov… 

    …erage
    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    1614a28 View commit details
    Browse the repository at this point in the history

  20. refactor!: replaced custom Parse trait with std's FromStr

    @AurumTheEnd
    AurumTheEnd committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    0ff14b6 View commit details
    Browse the repository at this point in the history