Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve performance of amber sort #680

Closed
wants to merge 1 commit into from
Closed

Conversation

noahnu
Copy link
Collaborator

@noahnu noahnu commented Jan 26, 2023

#657 (comment)

Addresses: #657

@codecov
Copy link

codecov bot commented Jan 26, 2023

Codecov Report

Merging #680 (9707a5c) into next (4ca0716) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             next     #680   +/-   ##
=======================================
  Coverage   98.57%   98.57%           
=======================================
  Files          20       20           
  Lines        1402     1405    +3     
=======================================
+ Hits         1382     1385    +3     
  Misses         20       20           

@noahnu
Copy link
Collaborator Author

noahnu commented Jan 26, 2023

Not seeing a perf improvement.

@noahnu noahnu closed this Jan 26, 2023
@noahnu noahnu deleted the perf_sort_order branch January 26, 2023 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant