Stable rust: Remove unstable impl trait from Tari comms #3056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delta1
reviewed
Jul 6, 2021
- Uses `async_trait` for the comms `Transport` trait - Transport trait results/futures are flattened/simplified - Replace impl Trait usage in RPC services to use boxed alternatives - Replace impl Trait usage in Tor control port module - Include the single remaining still unstable `is_unicast_link_local` function as copied code and remove `ip` feature.
sdbondi
force-pushed
the
comms-remove-impl-trait
branch
from
20a68f3
to
cec2273
Compare
Merged
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 18, 2021
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
2 tasks
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 18, 2021
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 18, 2021
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 18, 2021
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
sdbondi
added a commit
to sdbondi/tari
that referenced
this pull request
Jul 18, 2021
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
Cifko
pushed a commit
to Cifko/tari
that referenced
this pull request
Jul 21, 2021
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
async_traitfor the commsTransporttraitis_unicast_link_localfunction as copied code and remove
ipfeature.Motivation and Context
Move towards stable rust
Related to #3034
Ref #3037 #3035
How Has This Been Tested?
Existing tests updated and pass
Checklist:
developmentbranch.