feat: add support for /dns multiaddrs to dns resolver
#3105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdbondi
force-pushed
the
comms-dns-support-for-resolver
branch
2 times, most recently
from
73d8262
to
75d929f
Compare
sdbondi
changed the title
/dns multiaddrs to dns resolver/dns multiaddrs to dns resolver
sdbondi
force-pushed
the
comms-dns-support-for-resolver
branch
from
75d929f
to
8d5e1a0
Compare
- `Protocol::Dns` variant was missing from the system and tor DNS resolvers - This allows one to use `/dns` multiaddrs - [unrelated] async-trait should not be optional since tari-project#3056
sdbondi
force-pushed
the
comms-dns-support-for-resolver
branch
from
8d5e1a0
to
db384c0
Compare
stringhandler
approved these changes
Jul 19, 2021
stringhandler
changed the title
/dns multiaddrs to dns resolver/dns multiaddrs to dns resolver
|
PR queued successfully. Your position in queue is: 3 |
|
PR is on top of the queue now |
|
PR failed to merge with reason: Failed due to unknown reason |
|
PR queued successfully. Your position in queue is: 2 |
|
PR is on top of the queue now |
|
PR failed to merge with reason: Failed due to unknown reason |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Protocol::Dnsvariant was missing from the system and tor DNS resolvers/dnsmultiaddrsMotivation and Context
Users may miss the
4in/dns4when configuring tari applications./dnsis a valid multiaddr and should be supported.How Has This Been Tested?
Tested "manually" using
comms::transports::dns::tor::test::resolveChecklist:
developmentbranch.