Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added missing log4rs features #5356

Merged

Conversation

sdbondi
Copy link
Member

@sdbondi sdbondi commented Apr 26, 2023

Description

Added missing log4rs features to applications which use these features.

Motivation and Context

Base node panics because the sample log config uses a number of log4rs features that are not compiled in.
The dependency was not added to the common lib as this adds extra dependencies to a lot of libs and it breaks wasm build.

How Has This Been Tested?

Base node runs

What process can a PR reviewer use to test or verify this change?

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@ghpbot-tari-project ghpbot-tari-project added P-acks_required Process - Requires more ACKs or utACKs P-reviews_required Process - Requires a review from a lead maintainer to be merged labels Apr 26, 2023
@sdbondi sdbondi force-pushed the common-missing-log4rs-features branch 2 times, most recently from 8e31977 to 51cc350 Compare April 26, 2023 12:20
@sdbondi sdbondi force-pushed the common-missing-log4rs-features branch from 51cc350 to 0597040 Compare April 26, 2023 12:20
Copy link
Collaborator

@SWvheerden SWvheerden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@ghpbot-tari-project ghpbot-tari-project removed the P-reviews_required Process - Requires a review from a lead maintainer to be merged label May 3, 2023
@SWvheerden SWvheerden merged commit b9031bb into tari-project:development May 3, 2023
@sdbondi sdbondi deleted the common-missing-log4rs-features branch May 3, 2023 06:49
SWvheerden added a commit that referenced this pull request May 8, 2023
##
[0.50.0-pre.1](v0.50.0-pre.0...v0.50.0-pre.1)
(2023-05-08)


### Features

* add miner timeout config option
([5331](#5331))
([aea14f6](aea14f6))
* chat ffi ([5349](#5349))
([f7cece2](f7cece2))
* chat scaffold
([5244](#5244))
([5b09f8e](5b09f8e))
* improve message encryption
([5288](#5288))
([7a80716](7a80716))
* **p2p:** allow listener bind to differ from the tor forward address
([5357](#5357))
([857fb55](857fb55))


### Bug Fixes

* add SECURITY.md Vulnerability Disclosure Policy
([5351](#5351))
([72daaf5](72daaf5))
* added missing log4rs features
([5356](#5356))
([b9031bb](b9031bb))
* allow public addresses from command line
([5303](#5303))
([349ac89](349ac89))
* clippy issues with config
([5334](#5334))
([026f0d5](026f0d5))
* default network selection
([5333](#5333))
([cf4b2c8](cf4b2c8))
* make the first output optional in the wallet
([5352](#5352))
([bf16140](bf16140))
* remove wallet panic
([5338](#5338))
([536d16d](536d16d))
* wallet .h file for lib wallets
([5330](#5330))
([22a3a17](22a3a17))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-acks_required Process - Requires more ACKs or utACKs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants