-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Approximate Percentile #1
Comments
See also this TimescaleDB PR |
The t-digest implementation is merged. As far as I know there are three remaining open issues before the feature is done:
@WireBaron did I miss anything? |
I should convert the comments to proper rustdoc format and make a quick pass over them. I think there's also a serialization issue with not fully populated digests that needs to be tracked down. |
@WireBaron I'll have a quick run through of the code, see if I can find anything |
61: Misc t-digest cleaning r=JLockerman a=JLockerman I got distracted looking for the serialization issue mentioned in #1, and did some experimental cleaning for the t-digest files, @WireBaron would you let me know what you think? Rename the type exposed to SQL to `tdigest` instead of `TimescaleTDigest`. Remove the auxiliary hand-written SQL files in favor of including the SQL directly in the rust files; it should be easier to keep them in sync that way. Co-authored-by: Joshua Lockerman <josh@timescale.com>
Am experimental version of this is available in 0.1.0, and should also be available on Forge soon. |
See also #35 |
see also #41 |
This was released in 1.0.0 |
What's the functionality you would like to add
An approximate percentile function such as t-digest. This would have two main advantages over
percentile_cont
:How would the function be used
Basic percentile calculation works just like exat percentile calculation, expect it takes in an accuracy measure (for t-digest the number of centroids)
When storing the data, for instance in continuous aggregates, the digest itself can be stored, instead of the percentile, allowing future analysis to chose which data it wants to get out.
Open Questions
TBD
Remaining Work
The text was updated successfully, but these errors were encountered: