Misc t-digest cleaning #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the type exposed to SQL to tdigest instead of TimescaleTDigest. Remove the auxiliary hand-written SQL files in favor of including the SQL directly in the rust files; it should be easier to keep them in sync that way.
JLockerman
force-pushed
the
jl/tdigest-cleaning
branch
from
22908ce
to
7b0e978
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got distracted looking for the serialization issue mentioned in #1, and did some experimental cleaning for the t-digest files, @WireBaron would you let me know what you think?
Rename the type exposed to SQL to
tdigestinstead ofTimescaleTDigest.Remove the auxiliary hand-written SQL files in favor of including the SQL directly in the rust files; it should be easier to keep them in sync that way.