We missed a place to update the cargo-pgx version.

[epgts]

We really need to get a handle on this...

[epgts]

Why don't we run .github/workflows/patch_build.yml on every pull request?
Currently we limit it to

    paths:
      - 'docker/patch/**'
      - '.github/workflows/patch_build.yml'

but that means we miss breaking changes like the pgx upgrade.

Any change to the inputs to cargo pgx install or cargo run --manifest-path ../tools/post-install/Cargo.toml need to execute this to detect breakage... and that's almost everything.

[rtwalker]

Apparently when running sql-doctester under patch_build, the extension
needs to be DROPped first. Make tools/build DROP and switch to that.

From CI error message:

thread 'main' panicked at 'could not run init script: Error { ... message: "extension "timescaledb" does not exist" ... }', tools/sql-doctester/src/runner.rs:102:14

Do you want DROP EXTENSION IF EXISTS?

[rtwalker]

We really need to get a handle on this...

Agreed. Thanks for leaving the comment hints in the appropriate places! Wonder what else we can do for this?

[epgts]

Do you want DROP EXTENSION IF EXISTS?

That's probably a good idea so I added that, but the problem here was that BOTH extensions already exist. I reproduced that problem locally and now it's gone. Here goes...

@JLockerman am I papering over a problem rather than fixing it? How was this supposed to work? Why didn't the extension exist last time you ran it, but now it does?

[JLockerman]

@epgts the doctester spins up a new DB for each file; I don't see how the extension could already be installed since we don't install it on the template. That said, I think the best way to avoid already-installed errors is probably to use CREATE EXTENSION IF NOT EXISTS, ie. CREATE EXTENSION IF NOT EXISTS timescaledb; CREATE EXTENSION timescaledb_toolkit;

[epgts]

Well both extensions are definitely already there :( So I think I have only papered over a problem we need to instead understand. But no one needs this to work right now so I am going to file an issue and leave it broken for now. Thanks.