-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support running on PostgreSQL 15 #664
Conversation
The CI for this PR fails on PG15:
I got a similar failure the first time I ran the doc-tests locally, the second and third times I got strange results. |
f301a38
to
cf2040a
Compare
352470f
to
cbf5064
Compare
The CI passes when run with the updated Docker image: https://github.com/timescale/timescaledb-toolkit/actions/runs/3830536476 |
cargo run --manifest-path ./tools/sql-doctester/Cargo.toml -- -h localhost -s "CREATE EXTENSION timescaledb_toolkit; SET SESSION TIMEZONE TO 'UTC'" -p 5432 docs | ||
cargo run --manifest-path ./tools/sql-doctester/Cargo.toml -- -h localhost -p 5432 docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This CI job has bitrotted and always fails to run (it's only run when certain files are modified). The patch Docker image should probably be completely removed in a future PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
motion seconded
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I asked @JLockerman if I could get rid of it the first time I tripped over it (PR #442). At the time, he thought it was still useful, though I can't find any written record of our conversation about it.
I think it's pretty clear we don't need it now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah this thing only ever had a very specific use–getting a version of the current TimescaleDB docker image with the latest dev version of Toolkit installed–and was only ever useful as an internal debugging tool. It was always rather brittle, and if we're not finding it useful anymore we might as well delete it.
670: Add PG15 support to Docker image r=Smittyvb a=Smittyvb This PR has just the Docker image changes from #664. ([CI run](https://github.com/timescale/release-build-scripts/actions/runs/3831893814)) Co-authored-by: Smitty <smitty@timescale.com>
bors r+ |
Build succeeded: |
674: Remove bitrotted patch image r=Smittyvb a=Smittyvb The `patch` Docker image hasn't been successfully built for 8 months, and the job to build it always fails due to an authentication error. Even if it got past that issue, it would still fail since it's still using pgx 0.2. This PR removes the image and the CI job that builds it. (originally noted at #664 (comment)) Co-authored-by: Smitty <smitty@timescale.com>
674: Remove bitrotted patch image r=Smittyvb a=Smittyvb The `patch` Docker image hasn't been successfully built for 8 months, and the job to build it always fails due to an authentication error. Even if it got past that issue, it would still fail since it's still using pgx 0.2. This PR removes the image and the CI job that builds it. (originally noted at #664 (comment)) Co-authored-by: Smitty <smitty@timescale.com>
Fixes #648.
setseed
random
function on pg12/pg13Things to fix in release-build-scripts (these don't block this PR):
package curl-minimal-7.76.1-19.el9.x86_64 conflicts with curl provided by curl-7.76.1-19.el9.x86_64
)