B 20943

[CoryKleinjanCACI]

B-20943

B-20944

B-20945

Int Review

Int Review V2

Int Review V3

Summary

Fixes improper use of the SIT estimated entry and departure dates instead of actual dates on payment packets. Also fixed issue where days in storage was calculated using estimated instead of actual dates for SIT on payment packets.

Verification Steps for the Author

These are to be checked by the author.

• Tested in the Experimental environment (for changes to containers, app startup, or connection to data stores)
• Have the Agility acceptance criteria been met for this change?

Verification Steps for Reviewers

These are to be checked by a reviewer.

• Has the branch been pulled in and checked out?
• Have the BL acceptance criteria been met for this change?
• Was the CircleCI build successful?
• Has the code been reviewed from a standards and best practices point of view?

Setup to Run the Code

• Instructions for starting storybook
• Instructions for starting the MilMove application
• Instructions for running tests

How to test

1. Access the Milmove application
2. Login as a customer
3. Create a PPM, ensure that it has storage planned
4. Submit the PPM
5. Login as a Service Counselor
6. Submit move details for your created move
7. Login as the Customer you create the PPM for
8. Upload documents and enter Storage Expense details for the PPM (pick different actual dates that estimated dates entered previously for ease of testing)
9. Login as a Service Counselor
10. Review the documents and approve the storage
11. Login as the Customer
12. Download the Payment Packet
13. Ensure the Actual dates listed on the Storage Expense object are used on the packet, and not the estimated dates
14. Login as a Service Counselor
15. Locate the PPM you created
16. Download the Payment Packet
17. Ensure the Actual dates listed on the Storage Expense object are used on the packet, and not the estimated dates

Frontend

• There are no aXe warnings for UI.
• This works in Supported Browsers and their phone views (Chrome, Firefox, Edge).
• There are no new console errors in the browser devtools.
• There are no new console errors in the test output.
• If this PR adds a new component to Storybook, it ensures the component is fully responsive, OR if it is intentionally not, a wrapping div using the officeApp class or custom min-width styling is used to hide any states the would not be visible to the user.
• This change meets the standards for Section 508 compliance.

Backend

• Code follows the guidelines for Logging.
• The requirements listed in Querying the Database Safely have been satisfied.

Database

Any new migrations/schema changes:

• Follows our guidelines for Zero-Downtime Deploys.
• Have been communicated to #g-database.
• Secure migrations have been tested following the instructions in our docs.

Screenshots

[MInthavongsay]

Looks good!

[ajlusk]

Commits match INT

[traskowskycaci]

Matches integration PR outside of a few merge diffs, but code here does match integrationTesting.

[r-mettler]

matches with INT