Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NAS-130966 / 25.04 / Make sure we delete any app volume mount datasets created on app install failure #14544

Merged
merged 6 commits into from
Sep 20, 2024

Conversation

sonicaj
Copy link
Member

@sonicaj sonicaj commented Sep 19, 2024

This PR adds changes to remove any app volume mount datasets created during installation in the event installation process failed for whatever reason. We are picky on this end and make sure we only remove them if the app volume dataset didn't exist before as when a user deletes an app, it's optional for him/her to remove the app volume mounts datasets and we don't want them nuked if a user installs an app with the same name and app install fails for whatever reason.

@sonicaj sonicaj requested a review from a team September 19, 2024 16:34
@sonicaj sonicaj self-assigned this Sep 19, 2024
@bugclerk bugclerk changed the title Make sure we delete any app volume mount datasets created on app install failure NAS-130966 / 25.04 / Make sure we delete any app volume mount datasets created on app install failure Sep 19, 2024
@bugclerk
Copy link
Contributor

@Dremor
Copy link

Dremor commented Sep 19, 2024

I have a question : Will we be able to remove ti ix-volumes if we remove an app without choosing to remove the ix-volume at that time ? I'm currently stuck with multiple ix-volumes I cannot remove, and would like to be able to remove them.

@bugclerk
Copy link
Contributor

This PR has been merged and conversations have been locked.
If you would like to discuss more about this issue please use our forums or raise a Jira ticket.

@truenas truenas locked as resolved and limited conversation to collaborators Sep 20, 2024
@sonicaj
Copy link
Member Author

sonicaj commented Sep 20, 2024

I have a question : Will we be able to remove ti ix-volumes if we remove an app without choosing to remove the ix-volume at that time ? I'm currently stuck with multiple ix-volumes I cannot remove, and would like to be able to remove them.

@Dremor we would be adding some changes for FangTooth on this end so users can remove any ix-volumes which are not associated with any installed app.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants