Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-130966 / 25.04 / Make sure we delete any app volume mount datasets created on app install failure #14544

Merged
merged 6 commits into from
Sep 20, 2024
Merged

NAS-130966 / 25.04 / Make sure we delete any app volume mount datasets created on app install failure #14544

merged 6 commits into from
Sep 20, 2024

Commits on Sep 19, 2024

  1. Add logic to remove created ix volume on app creation failure

    @sonicaj
    sonicaj committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    3283bb1 View commit details
    Browse the repository at this point in the history

  2. Have a common method to clean up resources on app creation failure

    @sonicaj
    sonicaj committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    6c28af0 View commit details
    Browse the repository at this point in the history

  3. Only remove app volume ds if it didn't exist before

    @sonicaj
    sonicaj committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    17ccea4 View commit details
    Browse the repository at this point in the history

  4. Minor fix

    @sonicaj
    sonicaj committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    5e85cfa View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2024

  1. Remove complicated for loop

    @sonicaj
    sonicaj committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1e09fe1 View commit details
    Browse the repository at this point in the history

  2. Log failure when removing app volume ds if there is one

    @sonicaj
    sonicaj committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    2b274ff View commit details
    Browse the repository at this point in the history