NAS-131365 / 25.04 / Better error message for bad storj bucket name

[creatorcary]

Currently the returned error message is "An error occurred (InvalidBucketName) when calling the CreateBucket operation: The specified bucket is not valid." To save the user some research, we can clarify this message to "Bucket name can only contain lowercase letters, numbers, and hyphens" which is verbatim in the storj documentation.

[bugclerk]

Jira URL: https://ixsystems.atlassian.net/browse/NAS-131365

[william-gr]

Should we improve validation error too? IIRC it accepts uppercase there now
I dont know if Storj issue is starting with uppercase or any uppercase

[creatorcary]

IIRC it accepts uppercase there now I dont know if Storj issue is starting with uppercase or any uppercase

I tested on a vm and it doesn't accept any caps. Here's the exact restrictions on bucket names that I found.

[creatorcary]

IMHO I don't know about hard-coding the business logic of a third party like this. It might be better to leave the current error message and only change the webui validation.

[william-gr]

Well, if there are clear restrictions on bucket names, we dont we validate it just like we do anything else, like dataset/pool names?

Right now all we have is: Str("bucket", required=True, empty=False) ?

[themylogin]

I agree with the current approach (only rewording the message).

However, what if the bucket already exists? Did you test that it would not be an InvalidName error?

[yocalebo]

I spoke directly with Logan and we can actually make this a bit more proper, going to close this and he'll push another PR.