Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NAS-131365 / 25.04 / Better error message for bad storj bucket name #14564

Closed
wants to merge 2 commits into from
Closed

NAS-131365 / 25.04 / Better error message for bad storj bucket name #14564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e9cc0ee
test
creatorcary Sep 23, 2024
37c1291
narrow validation
creatorcary Sep 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/middlewared/middlewared/rclone/remote/storjix.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,11 @@ def create_bucket_sync():
s3_client.create_bucket(Bucket=name)
except s3_client.exceptions.BucketAlreadyExists as e:
raise CallError(str(e), errno=errno.EEXIST)
except botocore.exceptions.ClientError as e:
if "InvalidBucketName" in e.args[0]:
raise CallError("Bucket name can only contain lowercase letters, numbers, and hyphens.",
errno.EINVAL, str(e))
raise

return await self.middleware.run_in_thread(create_bucket_sync)

Expand Down
Loading