-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VCF writer gives cryptic error when nodes with an individual are not flagged as samples #2257
Comments
At the same time give an nice error if there are individuals with no nodes, currently results in a KeyError. |
The issue Shing was hitting here is having a bunch of unreferenced individuals in the data model. Probably the right thing to is to tolerate this but to emit a warning (ignoring x individuals with no corresponding nodes). If the individual does refer to a node, but the node is not a sample then this should be an error I think. |
Moving this up as we need it to generate VCFs for the pedigree generated tree sequences here: https://zenodo.org/record/6839683#.Yt-v43XMKEI They contain individuals in the pedigree that are not samples - which is a perfectly reasonable thing to do, so we need to come up with a reasonable approach to dealing with this, which does the right thing in this instance. |
Closes tskit-dev#2257 Interface tweaks. Add explict error text to vcf tests
Closes tskit-dev#2257 Interface tweaks. Add explict error text to vcf tests
Closes tskit-dev#2257 Closes tskit-dev#2446 Closes tskit-dev#2448
Closes tskit-dev#2257 Closes tskit-dev#2446 Closes tskit-dev#2448
Currently, if you try to dump a VCF of a tree sequence where the nodes that have individuals are not sample nodes you get the error:
LibraryError: Cannot generate genotypes for non-samples when isolated nodes are considered as missing
I think the VCF code should give an earlier error as it puts together the list of samples.
The text was updated successfully, but these errors were encountered: