Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw_svg option to suppress site/mutation rendering #2516

Closed
jeromekelleher opened this issue Sep 26, 2022 · 7 comments · Fixed by #2519
Closed

draw_svg option to suppress site/mutation rendering #2516

jeromekelleher opened this issue Sep 26, 2022 · 7 comments · Fixed by #2519
Assignees
Labels
enhancement New feature or request Visualisation This issue addresses visualisation
Milestone

Comments

@jeromekelleher
Copy link
Member

When working with large data trees we often want to do a quick viz of a subset of the nodes. However, when we have thousands of sites and mutations on it, it takes ages and we can't really see the tree.

Is there an easy way to supress sites and mutations? Can we add an option to stop them getting added to the SVG?

Ping @hyanwong

@jeromekelleher jeromekelleher added enhancement New feature or request Visualisation This issue addresses visualisation labels Sep 26, 2022
@benjeffery
Copy link
Member

I guess you just clear the tables? But would be nice to have some syntatic sugar for that.

@jeromekelleher
Copy link
Member Author

It's bit tedious having to dump the tables and create a new ts. For quick exploratory stuff I'd like to do:

big_ts.simplify(big_ts.samples()[:10]).draw_svg(suppress_sites=True)

@hyanwong
Copy link
Member

hyanwong commented Sep 26, 2022

If it's the viz that's slow (rather than the generation) you could hide them with CSS (style=".mut, .site: display:None") and provide syntactic sugar for that instead. But if could be that makes a huge and unwieldy SVG.

@jeromekelleher
Copy link
Member Author

It'll be massive - we're talking about 10s of thousands of sites here.

@hyanwong
Copy link
Member

Yeah, an option to omit them seems sensible.

@jeromekelleher
Copy link
Member Author

Are you happy to pick this one up for the next release @hyanwong?

@hyanwong
Copy link
Member

Yep, fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Visualisation This issue addresses visualisation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants