Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omit_sites parameter to draw/svg #2519

Merged
merged 1 commit into from
Sep 27, 2022
Merged

Conversation

hyanwong
Copy link
Member

@hyanwong hyanwong commented Sep 26, 2022

Fixes #2516

PR Checklist:

  • Tests that fully cover new/changed functionality.
  • Documentation including tutorial content if appropriate.
  • Changelogs, if there are API changes.

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Merging #2519 (ead67f4) into main (bf37451) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2519   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          27       27           
  Lines       27193    27195    +2     
  Branches     1264     1265    +1     
=======================================
+ Hits        25537    25539    +2     
  Misses       1622     1622           
  Partials       34       34           
Flag Coverage Δ
c-tests 92.24% <ø> (ø)
lwt-tests 89.05% <ø> (ø)
python-c-tests 73.17% <0.00%> (-0.02%) ⬇️
python-tests 98.95% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
python/tskit/trees.py 98.74% <ø> (ø)
python/tskit/drawing.py 98.99% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf37451...ead67f4. Read the comment docs.

Copy link
Member

@benjeffery benjeffery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hyanwong

@benjeffery benjeffery added the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Sep 27, 2022
@mergify mergify bot merged commit a81d340 into tskit-dev:main Sep 27, 2022
@mergify mergify bot removed the AUTOMERGE-REQUESTED Ask Mergify to merge this PR label Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

draw_svg option to suppress site/mutation rendering
2 participants