Make metadata decoding eager. #2432
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
- Coverage 93.34% 93.33% -0.01%
==========================================
Files 28 28
Lines 27006 26967 -39
Branches 1253 1246 -7
==========================================
- Hits 25209 25170 -39
Misses 1763 1763
Partials 34 34
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
See #2439 for the quick solution to memory leak, borrowing ideas from this PR. Closing this PR as making things fully eager is a step too far. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One potential approach to solving #2431
This might be too extreme though, because it makes all metadata encoding eager, and so there may be performance implications when, say, iterating over the nodes in a tree sequence without accessing the metadata (when there is significant metadata present).
This showed up some problems in the test suite where we have undecodable metadata in one of the example legacy tree sequences.