Convert DFatal => DPanic(Level) #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshayjshah
approved these changes
Dec 6, 2016
| @@ -63,6 +63,8 @@ const ( | |||
| // ErrorLevel logs are high-priority. If an application is running smoothly, | |||
| // it shouldn't generate any error-level logs. | |||
| ErrorLevel | |||
| // DPanicLevel logs an error message, but panics only in development. | |||
There was a problem hiding this comment.
nit: To me, this would be clearer as "DPanicLevel logs are particularly important errors. In development, the logger panics after writing the message."
| // after all sub-loggers have received the message, then the Tee | ||
| // terminates the process (using os.Exit or panic() per usual | ||
| // semantics). | ||
| // Exceptions are made for the DPyanic, Panic, and Fatal methods: the returned |
| // level; each sub-logger's DFatal method dynamically chooses to either call | ||
| // Error or Fatal. | ||
| // NOTE: DPanic will currently never panic, since the Tee Logger does not | ||
| // accept options (nor even have a development flag). |
There was a problem hiding this comment.
Please file an issue for this, so we can make sure to fix this before 1.0.
| } | ||
| func (ml multiLogger) DPanic(msg string, fields ...Field) { | ||
| ml.log(DPanicLevel, msg, fields) | ||
| // TODO: Implement development/DPanic? |
There was a problem hiding this comment.
As mentioned above, let's track this via issues.
There was a problem hiding this comment.
indeed, #202 should get it.
| @@ -71,6 +76,9 @@ func (c *counters) Reset(key string) { | |||
| // FatalLevel, if it happens is sampled and will call the underlying logger Log | |||
| // method, which should NOT panic() or terminate. | |||
| // | |||
| // NOTE: logging at DPanic level currently IS sampled, but calls to DPanic and | |||
| // Check(DPanicLevvel) are NOT sampled. | |||
There was a problem hiding this comment.
spelling: "DPanicLevel"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175.
Doing this ahead of coming interface-pocalypse discused with @akshayjshah et al (mentioned in the tabled #194).