Add ByteString API #366
Merged
Add ByteString API #366
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great - nicely done. I'm going to push a small change (less use of named returns), and I'm going to benchmark whether it's worth adding a |
akshayjshah
force-pushed
the
bytestring
branch
2 times, most recently
from
45004b1
to
c7ba680
Compare
This is a breaking change that adds a `AddByteString` to `zapcore.ObjectEncoder`, `AppendByteString` to `zapcore.PrimitiveArrayEncoder`. This API optimizes logging UTF-8 encoded []byte data. Fixes uber-go#324.
akshayjshah
approved these changes
Mar 14, 2017
This is a breaking change that adds a `AddByteString` to `zapcore.ObjectEncoder`, `AppendByteString` to `zapcore.PrimitiveArrayEncoder`. This API optimizes logging UTF-8 encoded []byte data. Fixes uber-go#324.
To make logging bytestrings and binary more efficient, add a byte slice to the Field union. This adds ~80ns to the `AddingFields` benchmarks, but saves an allocation along a path that particularly performance-sensitive applications will use.
This reverts commit c7ba680.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change that adds bytestring APIs (to log UTF-8 encoded bytes) to
ObjectEncoderandArrayEncoder. To actually save allocations along this path, I also benchmarked adding a[]byteto the field union; this reduces the allocation count for bytestrings, but increases the cost of adding fields by ~50%.Fixes #324.