Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ByteString API #366

Merged
merged 6 commits into from
Mar 14, 2017
Merged

Add ByteString API #366

merged 6 commits into from
Mar 14, 2017

Commits on Mar 14, 2017

  1. Add ByteString API 

    This is a breaking change that adds a `AddByteString` to `zapcore.ObjectEncoder`, `AppendByteString` to `zapcore.PrimitiveArrayEncoder`.
This API optimizes logging UTF-8 encoded []byte data.

Fixes uber-go#324.
    @skipor
    skipor authored and Akshay Shah committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    a6000c8 View commit details
    Browse the repository at this point in the history

  2. Add ByteString API 

    This is a breaking change that adds a `AddByteString` to `zapcore.ObjectEncoder`, `AppendByteString` to `zapcore.PrimitiveArrayEncoder`.
This API optimizes logging UTF-8 encoded []byte data.

Fixes uber-go#324.
    @skipor
    skipor authored and Akshay Shah committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    166e149 View commit details
    Browse the repository at this point in the history

  3. Clean up initial implementation

    Akshay Shah committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    03e7655 View commit details
    Browse the repository at this point in the history

  4. Add Bytes to Field union 

    To make logging bytestrings and binary more efficient, add a byte slice to the
Field union. This adds ~80ns to the `AddingFields` benchmarks, but saves an
allocation along a path that particularly performance-sensitive applications
will use.
    Akshay Shah committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    c7ba680 View commit details
    Browse the repository at this point in the history

  5. Revert "Add Bytes to Field union" 

    This reverts commit c7ba680.
    Akshay Shah committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    ee7e325 View commit details
    Browse the repository at this point in the history

  6. Small comment fix

    Akshay Shah committed Mar 14, 2017
    Configuration menu
    Copy the full SHA
    3de17c0 View commit details
    Browse the repository at this point in the history