Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Umbraco.Web.UI: Removed parenthesis from compiler directive #15110

Merged
merged 1 commit into from
Nov 2, 2023

Conversation

jacksorjacksor
Copy link

Prerequisites

N/A

Description

Removed parenthesis from compiler directive as generates warning from Umbraco.Web.UI as part of #15015

Removes warning from Umbraco.Web.UI as part of umbraco#15015
Copy link

github-actions bot commented Nov 2, 2023

Hi there @jacksorjacksor, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@mikecp mikecp self-assigned this Nov 2, 2023
@mikecp
Copy link
Contributor

mikecp commented Nov 2, 2023

HI @jacksorjacksor ,

Thanks for your contribution and for helping reduce the amount of compile-time warnings we get 👍 Let's merge this now! 😁

I see this is your first PR to the Umbraco CMS, congratulations! 🎉
If you provide us with your account name on our.umbraco.com, @nul800sebastiaan will be very happy to assign our shiny contributor's badge to you 🥉

Thanks again, and we'll be looking forward to your next contributions 😁

Cheers!

@mikecp mikecp merged commit 7a57e88 into umbraco:contrib Nov 2, 2023
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants