Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warnings from Umbraco.Web.UI #16958

Merged

Conversation

emmagarland
Copy link
Contributor

Fixed warning SA1119 for Umbraco.Web.UI project

Fixed StyleCop warning SA1119 (unnecessary parenthesis) for Umbraco.Web.UI project, and no warnings show up in that project now.

Prerequisites

  • I have added steps to test this contribution in the description below

If there's an existing issue for this PR then this fixes: part of my issue #15015

Description

Continuation of removal of warnings per project - replicating change made in #15110, the original Startup.cs file, which wasn't pulled across into Program.cs when removed

Copy link

github-actions bot commented Aug 25, 2024

Hi there @emmagarland, thank you for this contribution! 👍

While we wait for one of the Core Collaborators team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@georgebid georgebid self-assigned this Aug 27, 2024
@georgebid georgebid merged commit 148d51b into umbraco:contrib Aug 27, 2024
5 of 7 checks passed
@georgebid
Copy link
Contributor

Hey @emmagarland, thanks for the PR, I have taken a look at this and all looks good, therefore I have gone ahead and merged this one! 💯

@emmagarland
Copy link
Contributor Author

Amazing! Thanks @georgebid 👍

@emmagarland emmagarland deleted the hotfix/15015-removewarnings-umbracowebui branch August 27, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants