Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V14: Deleted code marked as obsolete for V12 and V13 #15999

Merged
merged 9 commits into from
Apr 8, 2024
Merged

V14: Deleted code marked as obsolete for V12 and V13 #15999

merged 9 commits into from
Apr 8, 2024

Conversation

elit0451
Copy link
Member

@elit0451 elit0451 commented Apr 5, 2024

Details

  • Deleted code marked as obsolete for V12 & V13;
    • Removed LegacyStaticServiceProvider and fixed using statements of StaticServiceProvider - using Umbraco.Cms.Core.DependencyInjection; instead of using Umbraco.Cms.Web.Common.DependencyInjection;;
    • Fixed implementation, referencing the obsoleted (deleted) methods/ctors - followed the instructions on the obsoleted msg.

Test

  • Run a smoke test.

nikolajlauridsen
nikolajlauridsen approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and nothing seems to have blown up when I smoke test 🎉

@nikolajlauridsen nikolajlauridsen merged commit e326370 into v14/dev Apr 8, 2024
15 of 16 checks passed
@nikolajlauridsen nikolajlauridsen deleted the v14/feature/more-obsoletion-cleanup branch April 8, 2024 09:17
@glitchedmob glitchedmob mentioned this pull request Aug 22, 2024
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikolajlauridsen nikolajlauridsen nikolajlauridsen approved these changes

Assignees
No one assigned
Labels
release/14.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elit0451 @nikolajlauridsen @bergmania