Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legacy ProviderName in sqlite examples #6369

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

glitchedmob
Copy link
Contributor

Description

While upgrading an Umbraco site using Sqlite from v13 to v14 I kept getting the following error: System.ArgumentException: The specified invariant name 'Microsoft.Data.SQLite' wasn't found in the list of registered .NET Data Providers.

I was using the exact values from the docs for umbracoDbDSN_ProviderName which made this error very confusing.

After some source diving and looking at the git history, I found umbraco/Umbraco-CMS#15999 which removed support for the format mentioned in the docs.

This PR updates the examples for version 14 to use the correct format. It may make sense to update the docs for versions 12 and 13 as well as it seems this format has been deprecated for a while.

It also may be worth updating the Breaking Changes section of the Version Specific Upgrades page.

I'm happy to add those suggested changes to this PR if the maintainers would prefer that.

Type of suggestion

  • Typo/grammar fix
  • Updated outdated content
  • New content
  • Updates related to a new version
  • Other

Product & version (if relevant)

Umbraco.Cms 14

Deadline (if relevant)

No Deadline

@sofietoft
Copy link
Contributor

Thanks for the PR @glitchedmob ! Good catch 💪

It would be great to have this added as a bullet to the version-specific upgrades.
If you're up for it, please don't hold back adding it to the PR 😄

Otherwise, I'll make sure we add it to our internal backlog in the docs team 🙌

@glitchedmob
Copy link
Contributor Author

@sofietoft Added this to the breaking changes in v14. Let me know if there are any adjustments I should make! (also feel free to take over and make the changes yourself if that's easier)

Copy link
Contributor

@sofietoft sofietoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @glitchedmob ! 💪 Thanks!
I took the libery to make some minor adjustments directly.

Regarding adding info about it to versions 12 and 13, I don't think it necessary.
It's only in Umbraco 14 that the obsolete provider name was removed and becomes a problem.

@sofietoft sofietoft merged commit 2e6d225 into umbraco:main Aug 23, 2024
13 checks passed
@glitchedmob glitchedmob deleted the fix-sqlite-provider-name branch August 23, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants