V14: Deleted code marked as obsolete for V12 and V13 #15999
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 26 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Overall Code Complexity RuntimeState.cs
✅ Improving Code Health:
- Large Method UmbracoBuilder.Configuration.cs: AddConfiguration
- String Heavy Function Arguments IOHelper.cs
- Missing Arguments Abstractions AuditService.cs
- Primitive Obsession FileService.cs
- Constructor Over-Injection SystemTroubleshootingInformationTelemetryProvider.cs: SystemTroubleshootingInformationTelemetryProvider
- Constructor Over-Injection UmbracoRouteValueTransformer.cs: UmbracoRouteValueTransformer
- Constructor Over-Injection PackageMigrationRunner.cs: PackageMigrationRunner
- Constructor Over-Injection DatabaseBuilder.cs: DatabaseBuilder
- Constructor Over-Injection ScopeProvider.cs: ScopeProvider
- Constructor Over-Injection CacheInstructionService.cs: CacheInstructionService
- Constructor Over-Injection SystemTroubleshootingInformationTelemetryProvider.cs: SystemTroubleshootingInformationTelemetryProvider
- Constructor Over-Injection InstallHelper.cs: InstallHelper
- Constructor Over-Injection InstallHelper.cs: InstallHelper
- Constructor Over-Injection RuntimeState.cs: RuntimeState
- Constructor Over-Injection RuntimeState.cs: RuntimeState
- Constructor Over-Injection RuntimeState.cs: RuntimeState
- Constructor Over-Injection UmbracoRouteValueTransformer.cs: UmbracoRouteValueTransformer
- Constructor Over-Injection UmbracoRouteValueTransformer.cs: UmbracoRouteValueTransformer
- Constructor Over-Injection UmbracoRouteValueTransformer.cs: UmbracoRouteValueTransformer
- Complex Conditional UmbracoBuilderExtensions.cs: AddUmbracoSqliteSupport
- Complex Method CultureImpact.cs: TryCreate
- Bumpy Road Ahead CultureImpact.cs: TryCreate
- Excess Number of Function Arguments CultureImpact.cs: TryCreate
- Constructor Over-Injection AutoModelsNotificationHandler.cs: AutoModelsNotificationHandler
- Overall Code Complexity UmbracoRouteValueTransformer.cs
- Missing Arguments Abstractions UmbracoRouteValueTransformer.cs
Annotations
Check notice on line 53 in src/Umbraco.Cms.Persistence.Sqlite/UmbracoBuilderExtensions.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Complex Conditional
AddUmbracoSqliteSupport no longer has a complex conditional
Check notice on line 123 in src/Umbraco.Core/DependencyInjection/UmbracoBuilder.Configuration.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ Getting better: Large Method
AddConfiguration decreases from 93 to 74 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Check notice on line 205 in src/Umbraco.Core/Models/CultureImpact.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Complex Method
TryCreate is no longer above the threshold for cyclomatic complexity
Check notice on line 205 in src/Umbraco.Core/Models/CultureImpact.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Bumpy Road Ahead
TryCreate is no longer above the threshold for logical blocks with deeply nested code
Check notice on line 205 in src/Umbraco.Core/Models/CultureImpact.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Excess Number of Function Arguments
TryCreate is no longer above the threshold for number of arguments
Check notice on line 1 in src/Umbraco.Core/Services/FileService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ Getting better: Primitive Obsession
The ratio of primitive types in function arguments decreases from 57.45% to 56.99%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in src/Umbraco.Core/Services/LocalizedTextServiceFileSources.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
ℹ Getting worse: Overall Code Complexity
The mean cyclomatic complexity increases from 5.44 to 6.00, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 51 in src/Umbraco.Infrastructure/Install/InstallHelper.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
InstallHelper is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 51 in src/Umbraco.Infrastructure/Install/InstallHelper.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
InstallHelper is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check warning on line 1 in src/Umbraco.Infrastructure/Runtime/RuntimeState.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
❌ New issue: Overall Code Complexity
This module has a mean cyclomatic complexity of 5.00 across 8 functions. The mean complexity threshold is 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.
Check notice on line 70 in src/Umbraco.Infrastructure/Runtime/RuntimeState.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
RuntimeState is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 70 in src/Umbraco.Infrastructure/Runtime/RuntimeState.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
RuntimeState is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 70 in src/Umbraco.Infrastructure/Runtime/RuntimeState.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
RuntimeState is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 64 in src/Umbraco.Infrastructure/Scoping/ScopeProvider.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
ScopeProvider is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 1 in src/Umbraco.Infrastructure/Services/CacheInstructionService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 36.23% to 40.32%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 1 in src/Umbraco.Infrastructure/Services/CacheInstructionService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
CacheInstructionService is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ Getting better: Constructor Over-Injection
SystemTroubleshootingInformationTelemetryProvider decreases from 9 to 8 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
SystemTroubleshootingInformationTelemetryProvider is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 1 in src/Umbraco.Core/Services/AuditService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ Getting better: Missing Arguments Abstractions
The average number of function arguments decreases from 4.13 to 4.07, threshold = 4.00. The functions in this file have too many arguments, indicating a lack of encapsulation or too many responsibilities in the same functions. Avoid adding more.
Check notice on line 1 in src/Umbraco.Core/Services/AuditService.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 51.61% to 56.14%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.
Check notice on line 52 in src/Umbraco.Infrastructure/Install/PackageMigrationRunner.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
PackageMigrationRunner is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 79 in src/Umbraco.Infrastructure/Migrations/Install/DatabaseBuilder.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
DatabaseBuilder is no longer above the threshold for number of arguments. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
Check notice on line 30 in src/Umbraco.Infrastructure/ModelsBuilder/AutoModelsNotificationHandler.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ No longer an issue: Constructor Over-Injection
AutoModelsNotificationHandler is no longer above the threshold for number of arguments
Check notice on line 1 in src/Umbraco.Core/Media/UploadAutoFillProperties.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
ℹ Getting worse: Missing Arguments Abstractions
The average number of function arguments increases from 4.89 to 5.00, threshold = 4.00. The functions in this file have too many arguments, indicating a lack of encapsulation or too many responsibilities in the same functions. Avoid adding more.
Check notice on line 1 in src/Umbraco.Core/Media/UploadAutoFillProperties.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
ℹ Getting worse: Primitive Obsession
The ratio of primitive types in function arguments increases from 47.73% to 52.50%, threshold = 30.0%. The functions in this file have too many primitive types (e.g. int, double, float) in their function argument lists. Using many primitive types lead to the code smell Primitive Obsession. Avoid adding more primitive arguments.