Remove RTE embedded image handling + clean up file upload configuration #16025
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v14/dev)
succeeded
Apr 10, 2024 in 44s
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Declining Code Health: 1 findings(s) 🚩
- Improving Code Health: 2 findings(s) ✅
Details
🚩 Declining Code Health (highest to lowest):
- Code Duplication RichTextEditorPastedImagesTests.cs
✅ Improving Code Health:
- Missing Arguments Abstractions RichTextEditorPastedImages.cs
- Constructor Over-Injection RichTextEditorPastedImages.cs: RichTextEditorPastedImages
Annotations
Check notice on line 1 in src/Umbraco.Infrastructure/PropertyEditors/RichTextEditorPastedImages.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ Getting better: Missing Arguments Abstractions
The average number of function arguments decreases from 6.14 to 5.71, threshold = 4.00. The functions in this file have too many arguments, indicating a lack of encapsulation or too many responsibilities in the same functions. Avoid adding more.
Check notice on line 101 in src/Umbraco.Infrastructure/PropertyEditors/RichTextEditorPastedImages.cs
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
✅ Getting better: Constructor Over-Injection
RichTextEditorPastedImages decreases from 7 to 6 arguments, threshold = 5. This constructor has too many arguments, indicating an object with low cohesion or missing function argument abstraction. Avoid adding more arguments.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (v14/dev)
❌ New issue: Code Duplication
The module contains 4 functions with similar structure: Can_Handle_Multiple_Temp_Images,Can_Handle_Temp_Gif_Image,Can_Handle_Temp_Svg_Image,Does_Not_Create_Duplicates_Of_The_Same_Temp_Image. Avoid duplicated, aka copy-pasted, code inside the module. More duplication lowers the code health.
Loading