Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate member picker property editor value to V14 compatible format (and back again) #16149

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

kjac
Copy link
Contributor

@kjac kjac commented Apr 25, 2024

Prerequisites

  • I have added steps to test this contribution in the description below

Description

The member picker property editor stores the Udi of the picked member (or the integer Id in really old databases). However, the V14 client needs the member key to resolve the member data in the editor UI, so we need to translate the value back and forth.

Testing this PR

The member picker property editor UI should work and should be able to store and retrieve a picked member.

Important: The current member picker property editor UI supports picking multiple members. That's a mistake, which will be corrected soon. The editor only supports picking a single member in V13, and thus it should do the same in V14. In other words, don't expect this PR to work if you pick more than a single member 😆

Copy link
Member

@elit0451 elit0451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💪
Will merge soon

@elit0451 elit0451 merged commit 0e12b94 into v14/dev Apr 29, 2024
16 checks passed
@elit0451 elit0451 deleted the v14/fix/member-picker-propertye-editor-value branch April 29, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants