Translate member group picker property editor value to V14 compatible format (and back again) #16150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… format (and back again)
|
Looks good, tests good 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This is the member groups equivalent of #16149
The member group picker property editor stores a CSV of the picked member group integer IDs. However, the V14 client needs the member group keys to resolve the member group data in the editor UI, so we need to translate the value back and forth.
Note that we still need to retain the integer IDs when storing data. Eventually we should migrate these, but a content migration is not desirable for V14.
Testing this PR
The member group picker property editor UI should work and should be able to store and retrieve one or more picked member groups.