Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V13: fix 16663 #16866

Merged
merged 4 commits into from
Aug 13, 2024

Merge remote-tracking branch 'origin/v13/dev' into v13/bugfix/16663

eb36086
Select commit
Loading
Failed to load commit list.
Merged

V13: fix 16663 #16866

Merge remote-tracking branch 'origin/v13/dev' into v13/bugfix/16663
eb36086
Select commit
Loading
Failed to load commit list.
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/dev) failed Aug 13, 2024 in 46s

CodeScene PR Check

Code Health Quality Gates: FAILED

Change in average Code Health of affected files: +0.07 (5.30 -> 5.37)

  • Declining Code Health: 6 findings(s) 🚩

View detailed results in CodeScene

Details

🚩 Declining Code Health (highest to lowest):

  • Deep, Nested Complexity umb-rte-block-clipboard.component.js: rawRteBlockResolver
  • Complex Method umb-rte-block-clipboard.component.js: rawRteBlockResolver
  • Complex Conditional umb-rte-block-clipboard.component.js: replaceUdisOfObject
  • Complex Conditional umb-rte-block-clipboard.component.js: rawRteBlockResolver
  • Bumpy Road Ahead umb-rte-block-clipboard.component.js: replaceUdisOfObject
  • Bumpy Road Ahead umb-rte-block-clipboard.component.js: rawRteBlockResolver

Annotations

Check warning on line 83 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/blocks/umb-rte-block-clipboard.component.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Complex Method

rawRteBlockResolver has a cyclomatic complexity of 10, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check warning on line 43 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/blocks/umb-rte-block-clipboard.component.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Complex Conditional

replaceUdisOfObject has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 59 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/blocks/umb-rte-block-clipboard.component.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Complex Conditional

rawRteBlockResolver has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.

Check warning on line 49 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/blocks/umb-rte-block-clipboard.component.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Bumpy Road Ahead

replaceUdisOfObject has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 83 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/blocks/umb-rte-block-clipboard.component.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Bumpy Road Ahead

rawRteBlockResolver has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.

Check warning on line 83 in src/Umbraco.Web.UI.Client/src/views/propertyeditors/rte/blocks/umb-rte-block-clipboard.component.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/dev)

❌ New issue: Deep, Nested Complexity

rawRteBlockResolver has a nested complexity depth of 4, threshold = 4. This function contains deeply nested logic such as if statements and/or loops. The deeper the nesting, the lower the code health.