Fix previous patch #1199

vatlab · Jan 30, 2019 · 250c8b3 · 250c8b3
1 parent 3f6773b
commit 250c8b3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/sos/workflow_executor.py b/src/sos/workflow_executor.py
@@ -449,7 +449,7 @@ def resolve_dangling_targets(self, dag: SoS_DAG, targets: Optional[sos_targets]=
             # check auxiliary steps and see if any steps provides it
             remaining_targets = dangling_targets
             while remaining_targets:
-                target = remaining_targets[0]
+                target = remaining_targets.pop()
                 mo = self.match(target)
                 if not mo:
                     #
@@ -485,6 +485,7 @@ def resolve_dangling_targets(self, dag: SoS_DAG, targets: Optional[sos_targets]=
                                 f'No step to generate target {target}{dag.steps_depending_on(target, self.workflow)}')
                     if nodes:
                         resolved += 1
+                    # cannot resolve, but the step is numerically indexed so we just wait
                     continue
                 if len(mo) > 1:
                     # sos_step('a') could match to step a_1, a_2, etc, in this case we are adding a subworkflow

diff --git a/test/test_dag.py b/test/test_dag.py
@@ -1186,8 +1186,8 @@ def testMultiNamedOutput(self):
                        '''
 strict digraph "" {
 default;
-"A (A)";
-"A (A)" -> default;
+"A (B)";
+"A (B)" -> default;
 }
 ''')