Add verbosity flag to optionally prevent excessive std::cout writes #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Yeah we probably should have used ROS' output system instead of std::cout. Could you add the param into dlio.yaml as well? I'll merge it in afterwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since DLIO writes directly to
std::cout, as opposed to using ROS' output system (ROS_INFOetc.) it's difficult to control the amount of terminal output you get. For example, it was quite difficult for me to read the estimated attitudes and biases, as this got overwritten by the info box. This PR adds a verbosity flag which removes the info box from the terminal output, if set to false.