Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【確認待ち】見出しレベル変更メニューが水平から垂直に調整 #951

Merged
merged 6 commits into from
Jan 14, 2022

Conversation

shimotmk
Copy link
Contributor

見出しレベル変更メニューが水平から垂直に調整しました。
5.8、5.9で問題なく動作するか確認お願いします。
関連:WordPress/gutenberg#32926

ベースがコアのheading-level-dropdown.jsを参考にしていたので変更点を持ってきました。

event.stopPropagationを削除
関連 : WordPress/gutenberg#33632
vertical-heading-levelsに対応
関連 : WordPress/gutenberg#32926
WordPress5.8でcssが崩れるので独自のクラスを追加
@shimotmk shimotmk changed the title 見出しレベル変更メニューが水平から垂直に調整 【確認待ち】見出しレベル変更メニューが水平から垂直に調整 Jan 14, 2022
@shimotmk shimotmk marked this pull request as ready for review January 14, 2022 02:13
@shimotmk shimotmk linked an issue Jan 14, 2022 that may be closed by this pull request
Copy link
Contributor

@mthaichi mthaichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5.8/5.9で動作チェックしました。ありがとうございました。

@mthaichi mthaichi merged commit e2f2d70 into develop Jan 14, 2022
@mthaichi mthaichi deleted the fix/heading/heading-levels-menu/wp5.9 branch January 14, 2022 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

見出しレベルの変更でドロップダウンが崩れる
2 participants