Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【確認待ち】見出しレベル変更メニューが水平から垂直に調整 #951

Merged
merged 6 commits into from
Jan 14, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions editor-css/_editor_before.scss
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,8 @@ button.image-button:not(.button-delete) {
@import "./editor_before_icons";
// ボタン横並び編集用CSS
@import "./editor_before_button-outer";
// VK見出しCSS読み込み
@import "./editor_before_vk-heading";

// VK Outer 編集パネル
$color-danger: #dd3333;
Expand Down
12 changes: 12 additions & 0 deletions editor-css/_editor_before_vk-heading.scss
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
/*-------------------------------------------*/
/* vk blocks Heading Level Dropdown
/*-------------------------------------------*/
// WordPress5.8でcssが崩れるので独自のクラスを追加
.vk-blocks-heading-level-dropdown {
.components-popover__content {
min-width: auto;
> div {
padding: 8px;
}
}
}
1 change: 1 addition & 0 deletions readme.txt
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ e.g.

== Changelog ==

[ fix ][ Heading ] vertical heading levels for wp-5.9
[ fix ][ Border Box ] cope with custom color palette
[ Bug fix ] fix block style enqueue point

Expand Down
89 changes: 29 additions & 60 deletions src/blocks/heading/heading-level-dropdown.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
/**
* WordPress dependencies
*/
import {
Dropdown,
Toolbar,
ToolbarButton,
ToolbarGroup,
} from '@wordpress/components';
import { ToolbarDropdownMenu } from '@wordpress/components';
import { __, sprintf } from '@wordpress/i18n';
import { DOWN } from '@wordpress/keycodes';

/**
* Internal dependencies
Expand All @@ -17,66 +11,41 @@ import HeadingLevelIcon from './heading-level-icon';

const HEADING_LEVELS = [1, 2, 3, 4, 5, 6];

// WordPress5.8でcssが崩れるので独自のクラスを追加
const POPOVER_PROPS = {
className: 'block-library-heading-level-dropdown',
isAlternate: true,
className:
'block-library-heading-level-dropdown vk-blocks-heading-level-dropdown',
};

export default function HeadingLevelDropdown({ selectedLevel, onChange }) {
return (
<Dropdown
<ToolbarDropdownMenu
popoverProps={POPOVER_PROPS}
renderToggle={({ onToggle, isOpen }) => {
const openOnArrowDown = (event) => {
if (!isOpen && event.keyCode === DOWN) {
event.preventDefault();
event.stopPropagation();
onToggle();
}
};
icon={<HeadingLevelIcon level={selectedLevel} />}
label={__('Change heading level')}
controls={HEADING_LEVELS.map((targetLevel) => {
{
const isActive = targetLevel === selectedLevel;

return (
<ToolbarButton
aria-expanded={isOpen}
aria-haspopup="true"
icon={<HeadingLevelIcon level={selectedLevel} />}
label={__('Change heading level')}
onClick={onToggle}
onKeyDown={openOnArrowDown}
showTooltip
/>
);
}}
renderContent={() => (
<Toolbar
className="block-library-heading-level-toolbar"
label={__('Change heading level')}
>
<ToolbarGroup
isCollapsed={false}
controls={HEADING_LEVELS.map((targetLevel) => {
const isActive = targetLevel === selectedLevel;
return {
icon: (
<HeadingLevelIcon
level={targetLevel}
isPressed={isActive}
/>
),
title: sprintf(
// translators: %s: heading level e.g: "1", "2", "3"
__('Heading %d'),
targetLevel
),
isActive,
onClick() {
onChange(targetLevel);
},
};
})}
/>
</Toolbar>
)}
return {
icon: (
<HeadingLevelIcon
level={targetLevel}
isPressed={isActive}
/>
),
label: sprintf(
// translators: %s: heading level e.g: "1", "2", "3"
__('Heading %d'),
targetLevel
),
isActive,
onClick() {
onChange(targetLevel);
},
};
}
})}
/>
);
}