Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update swc_core to v0.87.10 #59834

Merged
merged 13 commits into from
Jan 2, 2024
Merged

Update swc_core to v0.87.10 #59834

merged 13 commits into from
Jan 2, 2024

Conversation

@kdy1 kdy1 self-assigned this Dec 21, 2023
@ijjk ijjk added the created-by: Turbopack team PRs by the Turbopack team. label Dec 21, 2023
@kdy1 kdy1 changed the title Update swc_core Update swc_core to v0.87.2 Dec 21, 2023
@ijjk
Copy link
Member

ijjk commented Dec 21, 2023

Stats from current PR

Default Build
General
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
buildDuration 12.8s 12.7s N/A
buildDurationCached 7.1s 6.2s N/A
nodeModulesSize 202 MB 202 MB
nextStartRea..uration (ms) 429ms 432ms N/A
Client Bundles (main, webpack)
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
193.HASH.js gzip 181 B 182 B N/A
3f784ff6-HASH.js gzip 53.3 kB 53.3 kB
433-HASH.js gzip 28.3 kB 28.4 kB N/A
framework-HASH.js gzip 45.2 kB 45.2 kB
main-app-HASH.js gzip 239 B 242 B N/A
main-HASH.js gzip 31.7 kB 31.7 kB N/A
webpack-HASH.js gzip 1.7 kB 1.7 kB N/A
Overall change 98.5 kB 98.5 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
_app-HASH.js gzip 194 B 195 B N/A
_error-HASH.js gzip 183 B 181 B N/A
amp-HASH.js gzip 504 B 502 B N/A
css-HASH.js gzip 321 B 321 B
dynamic-HASH.js gzip 2.5 kB 2.5 kB N/A
edge-ssr-HASH.js gzip 255 B 253 B N/A
head-HASH.js gzip 350 B 349 B N/A
hooks-HASH.js gzip 369 B 369 B
image-HASH.js gzip 4.28 kB 4.28 kB N/A
index-HASH.js gzip 255 B 256 B N/A
link-HASH.js gzip 2.61 kB 2.61 kB
routerDirect..HASH.js gzip 312 B 311 B N/A
script-HASH.js gzip 385 B 383 B N/A
withRouter-HASH.js gzip 307 B 308 B N/A
1afbb74e6ecf..834.css gzip 106 B 106 B
Overall change 3.4 kB 3.4 kB
Client Build Manifests
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
_buildManifest.js gzip 483 B 484 B N/A
Overall change 0 B 0 B
Rendered Page Sizes
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
index.html gzip 527 B 527 B
link.html gzip 540 B 540 B
withRouter.html gzip 523 B 521 B N/A
Overall change 1.07 kB 1.07 kB
Edge SSR bundle Size
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
edge-ssr.js gzip 93.7 kB 93.7 kB N/A
page.js gzip 147 kB 147 kB N/A
Overall change 0 B 0 B
Middleware size
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
middleware-b..fest.js gzip 623 B 625 B N/A
middleware-r..fest.js gzip 151 B 151 B
middleware.js gzip 37.4 kB 37.4 kB N/A
edge-runtime..pack.js gzip 1.92 kB 1.92 kB
Overall change 2.07 kB 2.07 kB
Next Runtimes
vercel/next.js canary vercel/next.js kdy1/issue-1682 Change
app-page-exp...dev.js gzip 168 kB 168 kB
app-page-exp..prod.js gzip 94.2 kB 94.2 kB
app-page-tur..prod.js gzip 94.9 kB 94.9 kB
app-page-tur..prod.js gzip 89.4 kB 89.4 kB
app-page.run...dev.js gzip 138 kB 138 kB
app-page.run..prod.js gzip 88.7 kB 88.7 kB
app-route-ex...dev.js gzip 24.1 kB 24.1 kB
app-route-ex..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.7 kB 16.7 kB
app-route-tu..prod.js gzip 16.3 kB 16.3 kB
app-route.ru...dev.js gzip 23.5 kB 23.5 kB
app-route.ru..prod.js gzip 16.3 kB 16.3 kB
pages-api-tu..prod.js gzip 9.38 kB 9.38 kB
pages-api.ru...dev.js gzip 9.65 kB 9.65 kB
pages-api.ru..prod.js gzip 9.37 kB 9.37 kB
pages-turbo...prod.js gzip 21.9 kB 21.9 kB
pages.runtim...dev.js gzip 22.5 kB 22.5 kB
pages.runtim..prod.js gzip 21.9 kB 21.9 kB
server.runti..prod.js gzip 49.4 kB 49.4 kB
Overall change 932 kB 932 kB
Commit: 2a69e22

@kdy1 kdy1 changed the title Update swc_core to v0.87.2 Update swc_core to v0.87.3 Dec 21, 2023
@ijjk
Copy link
Member

ijjk commented Dec 21, 2023

Failing test suites

Commit: 2a69e22

pnpm test test/integration/next-image-new/app-dir/test/index.test.ts

  • Image Component Default Tests > dev mode > should apply style inheritance for img elements but not wrapper elements
Expand output

● Image Component Default Tests › dev mode › should apply style inheritance for img elements but not wrapper elements

expect(received).toBe(expected) // Object.is equality

Expected: false
Received: null

  1208 |         }()
  1209 |       `)
> 1210 |       expect(allSpans).toBe(false)
       |                        ^
  1211 |     } finally {
  1212 |       if (browser) {
  1213 |         await browser.close()

  at Object.toBe (integration/next-image-new/app-dir/test/index.test.ts:1210:24)

Read more about building and testing Next.js in contributing.md.

@kdy1
Copy link
Member Author

kdy1 commented Dec 21, 2023

The test failure seems like a regression, and the relevant commit range is swc-project/swc@0bde652...37bb0e3

@kdy1
Copy link
Member Author

kdy1 commented Dec 22, 2023

The problematic PR is swc-project/swc#8399

@kdy1 kdy1 changed the title Update swc_core to v0.87.3 Update swc_core to v0.87.10 Jan 2, 2024
kdy1 added a commit to vercel/turborepo that referenced this pull request Jan 2, 2024
### Description

Update SWC crates

### Testing Instructions

Closes PACK-2173
next.js counterpart: vercel/next.js#59834
@kdy1 kdy1 marked this pull request as ready for review January 2, 2024 08:14
@kdy1 kdy1 enabled auto-merge (squash) January 2, 2024 08:14
@kdy1 kdy1 merged commit 82cd86d into canary Jan 2, 2024
66 of 71 checks passed
@kdy1 kdy1 deleted the kdy1/issue-1682 branch January 2, 2024 08:44
Zertsov pushed a commit to vercel/turborepo that referenced this pull request Jan 5, 2024
### Description

Update SWC crates

### Testing Instructions

Closes PACK-2173
next.js counterpart: vercel/next.js#59834
agustints pushed a commit to agustints/next.js that referenced this pull request Jan 6, 2024
### What?

Update SWC crates

### Why?

It's required to fix some next.js isssues

### How?

Closes PACK-2174
Turbopack counterpart: vercel/turborepo#6843

---


# Turbopack

* vercel/turborepo#6737 <!-- Nicholas Yang - feat:
Nice errors for shim flag parsing -->
* vercel/turborepo#6494 <!-- Justin Ridgewell -
Trace output's source maps through input's source map -->
* vercel/turborepo#6778 <!-- Will Binns-Smith -
turbopack-css: fix rule duplication -->
* vercel/turborepo#6807 <!-- Mehul Kar - fix: add
missing dependency to cargo lockfile -->
* vercel/turborepo#6809 <!-- Nicholas Yang -
refactor: Remove bookkeeping abstraction from turbo config -->
* vercel/turborepo#6838 <!-- Nicholas Yang - fix:
Allow for long symlinks by using append_link -->
* vercel/turborepo#6845 <!-- Donny/강동윤 - perf: Use
`&'static str` instead of `String` if possible -->
* vercel/turborepo#6843 <!-- Donny/강동윤 - Update
`swc_core` to `v0.87.10` -->
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the Turbopack team. locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants