perf: Use &'static str instead of String if possible
#6845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
6 Ignored Deployments
|
🟢 Turbopack Benchmark CI successful 🟢Thanks |
|
✅ This change can build |
🟢 CI successful 🟢Thanks |
ForsakenHarmony
approved these changes
Dec 21, 2023
kdy1
added a commit
to vercel/next.js
that referenced
this pull request
Jan 2, 2024
### What? Update SWC crates ### Why? It's required to fix some next.js isssues ### How? Closes PACK-2174 Turbopack counterpart: vercel/turborepo#6843 --- # Turbopack * vercel/turborepo#6737 <!-- Nicholas Yang - feat: Nice errors for shim flag parsing --> * vercel/turborepo#6494 <!-- Justin Ridgewell - Trace output's source maps through input's source map --> * vercel/turborepo#6778 <!-- Will Binns-Smith - turbopack-css: fix rule duplication --> * vercel/turborepo#6807 <!-- Mehul Kar - fix: add missing dependency to cargo lockfile --> * vercel/turborepo#6809 <!-- Nicholas Yang - refactor: Remove bookkeeping abstraction from turbo config --> * vercel/turborepo#6838 <!-- Nicholas Yang - fix: Allow for long symlinks by using append_link --> * vercel/turborepo#6845 <!-- Donny/강동윤 - perf: Use `&'static str` instead of `String` if possible --> * vercel/turborepo#6843 <!-- Donny/강동윤 - Update `swc_core` to `v0.87.10` -->
Zertsov
pushed a commit
that referenced
this pull request
Jan 5, 2024
### Description The proc-macro generates all calls, so we don't need to allocate. ### Testing Instructions Closes PACK-2177
agustints
pushed a commit
to agustints/next.js
that referenced
this pull request
Jan 6, 2024
### What? Update SWC crates ### Why? It's required to fix some next.js isssues ### How? Closes PACK-2174 Turbopack counterpart: vercel/turborepo#6843 --- # Turbopack * vercel/turborepo#6737 <!-- Nicholas Yang - feat: Nice errors for shim flag parsing --> * vercel/turborepo#6494 <!-- Justin Ridgewell - Trace output's source maps through input's source map --> * vercel/turborepo#6778 <!-- Will Binns-Smith - turbopack-css: fix rule duplication --> * vercel/turborepo#6807 <!-- Mehul Kar - fix: add missing dependency to cargo lockfile --> * vercel/turborepo#6809 <!-- Nicholas Yang - refactor: Remove bookkeeping abstraction from turbo config --> * vercel/turborepo#6838 <!-- Nicholas Yang - fix: Allow for long symlinks by using append_link --> * vercel/turborepo#6845 <!-- Donny/강동윤 - perf: Use `&'static str` instead of `String` if possible --> * vercel/turborepo#6843 <!-- Donny/강동윤 - Update `swc_core` to `v0.87.10` -->
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 25, 2024
…orepo#6845) ### Description The proc-macro generates all calls, so we don't need to allocate. ### Testing Instructions Closes PACK-2177
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…orepo#6845) ### Description The proc-macro generates all calls, so we don't need to allocate. ### Testing Instructions Closes PACK-2177
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Jul 29, 2024
…orepo#6845) ### Description The proc-macro generates all calls, so we don't need to allocate. ### Testing Instructions Closes PACK-2177
ForsakenHarmony
pushed a commit
to vercel/next.js
that referenced
this pull request
Aug 1, 2024
…orepo#6845) ### Description The proc-macro generates all calls, so we don't need to allocate. ### Testing Instructions Closes PACK-2177
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All calls are generated by the proc-macro, so we don't need to allocate.
Testing Instructions
Closes PACK-2177