-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
cedfaa2
to
28ffc85
Compare
@@ -1063,6 +1063,20 @@ struct ListFTIndexesResp { | |||
3: map<binary, FTIndex> (cpp.template = "std::unordered_map") indexes, | |||
} | |||
|
|||
enum QueryStatus { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
prefer state than status
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems no difference between these two words? Besides we have a lot struct defined as Status
now.
src/common/interface/meta.thrift
Outdated
2: QueryStatus status; | ||
3: i64 duration; | ||
4: binary query; | ||
// The session might transfor between query engines, but the query do not, we must |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
transfer
|
||
struct QueryDesc { | ||
1: common.Timestamp start_time; | ||
2: QueryStatus status; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
@@ -1063,6 +1063,20 @@ struct ListFTIndexesResp { | |||
3: map<binary, FTIndex> (cpp.template = "std::unordered_map") indexes, | |||
} | |||
|
|||
enum QueryStatus { | |||
RUNNING = 0x01, | |||
KILLING = 0x02, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we not need a finished or stopped state?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The finished queries will be removed.
@@ -46,5 +46,6 @@ using ZoneID = int32_t; | |||
|
|||
using SessionID = int64_t; | |||
|
|||
using ExecutionPlanID = int64_t; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Query id is better than plan id.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For compatibility considered, I want to keep the idea Query ID
for now, since we might have a truly global unique query id
in further future.
src/common/session/SessionManager.h
Outdated
@@ -0,0 +1,71 @@ | |||
/* Copyright (c) 2018 vesoft inc. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2021
|
||
E_QUERY_NOT_FOUND = -2073, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add to nebula-common/src/common/graph/Response.h
No description provided.