This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Slow query. #1152
Merged
Slow query. #1152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CPWstatic
added
depend on common
yixinglu
reviewed
Jun 29, 2021
CPWstatic
added
the
doc affected
Shylock-Hg
reviewed
Jun 30, 2021
| Then an SemanticError should be raised at runtime: $-.eid, Session ID must be an integer but was STRING | ||
| When executing query: | ||
| """ | ||
| SHOW ALL QUERIES |
There was a problem hiding this comment.
I don't think we should enable input/output of admin sentence.
laura-ding
reviewed
Jun 30, 2021
yixinglu
reviewed
Jun 30, 2021
Shylock-Hg
reviewed
Jun 30, 2021
laura-ding
reviewed
Jun 30, 2021
laura-ding
reviewed
Jun 30, 2021
yixinglu
previously approved these changes
Jul 1, 2021
laura-ding
previously approved these changes
Jul 1, 2021
| auto findPtr = activeSessions_.find(sid); | ||
| if (findPtr == activeSessions_.end()) { | ||
| VLOG(1) << "Create session id: " << sid << ", for user: " << userName; | ||
| auto sessionPtr = ClientSession::create(std::move(session), metaClient_); | ||
| sessionPtr->charge(); | ||
| activeSessions_[sid] = sessionPtr; | ||
| auto ret = activeSessions_.emplace(sid, sessionPtr); |
There was a problem hiding this comment.
Need to clear the queries of the session.
yixinglu
reviewed
Jul 1, 2021
| ->getMetaClient() | ||
| ->killQuery(std::move(killQueries)) | ||
| .via(runner()) | ||
| .thenValue([pro = std::move(pro), this](auto&& resp) mutable { |
There was a problem hiding this comment.
It's better to chain these async futures, otherwise you must handle the exception threw by killQuery interface.
auto metaClient = qctx()->getMetaClient();
return metaClient->listSession()
.via(runner())
.thenValue([metaClient](listResp){
// ...blabla
return metaClient->killQuery(killedQueries);
})
.thenValue([](auto &&resp){
// ... some status
return status;
});
laura-ding
previously approved these changes
Jul 1, 2021
laura-ding
previously approved these changes
Jul 1, 2021
yixinglu
previously approved these changes
Jul 1, 2021
yixinglu
approved these changes
Jul 2, 2021
laura-ding
approved these changes
Jul 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After
vesoft-inc/nebula-common#565
vesoft-inc/nebula-storage#495
We had design doc here: https://confluence.nebula-graph.io/pages/viewpage.action?pageId=10719400