This repository has been archived by the owner on Dec 1, 2022. It is now read-only.
Rewrite lookup index selection implementation #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yixinglu
force-pushed
the
refactor-lookup-index
branch
2 times, most recently
from
3f76b5e
to
4f53fa5
Compare
yixinglu
force-pushed
the
refactor-lookup-index
branch
from
4f53fa5
to
34b04ac
Compare
CPWstatic
reviewed
Jul 1, 2021
yixinglu
force-pushed
the
refactor-lookup-index
branch
from
5dc7c27
to
c9538bd
Compare
|
Really big change, could provide an overview explanation? |
yixinglu
force-pushed
the
refactor-lookup-index
branch
from
9859dc6
to
014fb2f
Compare
of course, here is some thoughts when implementing this PR. I'll refine this document later. |
Shylock-Hg
reviewed
Jul 2, 2021
Shylock-Hg
reviewed
Jul 2, 2021
yixinglu
requested review from
bright-starry-sky,
nevermore3,
Aiee,
CPWstatic,
czpmango,
jievince and
laura-ding
CPWstatic
approved these changes
Jul 3, 2021
Comment on lines
+766
to
+772
| if (!getIndexColumnHintInExpr(field, expr, &hint, &operands)) { | ||
| break; | ||
| } | ||
| result.hints.emplace_back(std::move(hint)); | ||
| for (auto op : operands) { | ||
| usedOperands.insert(op); | ||
| } |
There was a problem hiding this comment.
Could give some comments? If the first column is EQ logic expression, the error will be returned via line 775?
There was a problem hiding this comment.
EQ expression is relational expression, this case will be handled by selectRelExprIndex function.
bright-starry-sky
approved these changes
Jul 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1061