add step fail hook #3384
Merged
add step fail hook #3384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3384 +/- ##
==========================================
- Coverage 85.27% 85.23% -0.04%
==========================================
Files 1276 1276
Lines 118999 119002 +3
==========================================
- Hits 101475 101437 -38
- Misses 17524 17565 +41
Continue to review full report at Codecov.
|
yixinglu
approved these changes
Dec 1, 2021
darionyaphet
reviewed
Dec 1, 2021
| @@ -64,6 +65,16 @@ def pytest_addoption(parser): | |||
| help="Nebula Graph workspace") | |||
|
|
|||
|
|
|||
| def pytest_bdd_step_error(request, feature, scenario, step, step_func, step_func_args): | |||
There was a problem hiding this comment.
pytest_bdd_step_error not by called? Or how to register the hook？
There was a problem hiding this comment.
it registered by pytest automatically.
- pytest scan
conftest - match the same definition with hook in pytest-bdd.
https://github.com/pytest-dev/pytest-bdd/blob/master/pytest_bdd/plugin.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://discuss.nebula-graph.com.cn/t/topic/6707/2
What type of PR is this?
What does this PR do?
currently, we just display error information in
cmp_datasetfunction, if there's any error not in the function, we cannot find more details.so add step error hook, and display space if using a random space.