Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix startup service failed when log directory not exists and enable_breakpad #4623

Conversation

panda-sheep
Copy link
Contributor

@panda-sheep panda-sheep commented Sep 6, 2022

…reakPad

What type of PR is this?

  • bug
  • feature
  • enhancement

What problem(s) does this PR solve?

Issue(s) number:

Description:

In the released installation package, when ENABLE_BREAKPAD is enabled, if the log directory does not exist, it will fail to start meta/stroage (storagelistener).

Many versions have this problem.

close https://github.com/vesoft-inc/nebula-ent/issues/1257

How do you solve it?

Special notes for your reviewer, ex. impact of this fix, design document, etc:

Checklist:

Tests:

  • Unit test(positive and negative cases)
  • Function test
  • Performance test
  • N/A

Affects:

  • Documentation affected (Please add the label if documentation needs to be modified.)
  • Incompatibility (If it breaks the compatibility, please describe it and add the label.)
  • If it's needed to cherry-pick (If cherry-pick to some branches is required, please label the destination version(s).)
  • Performance impacted: Consumes more CPU/Memory

Release notes:

Please confirm whether to be reflected in release notes and how to describe:

ex. Fixed the bug .....

@panda-sheep panda-sheep force-pushed the fix_startup_service_failed_when_log_directory_not_exists branch from dc83698 to bf024e4 Compare September 6, 2022 10:56
Copy link
Contributor

@wenhaocs wenhaocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done

@Sophie-Xie Sophie-Xie merged commit 3c6aea5 into vesoft-inc:master Sep 7, 2022
@panda-sheep panda-sheep deleted the fix_startup_service_failed_when_log_directory_not_exists branch September 7, 2022 03:30
@Sophie-Xie Sophie-Xie added the affects/v3.2 PR/issue: this bug affects v3.2.x version. label Sep 9, 2022
@Sophie-Xie Sophie-Xie removed the affects/v3.2 PR/issue: this bug affects v3.2.x version. label Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review ready-for-testing PR: ready for the CI test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants